|
| 1 | +# Copyright (c) The OGX Contributors. |
| 2 | +# All rights reserved. |
| 3 | +# |
| 4 | +# This source code is licensed under the terms described in the LICENSE file in |
| 5 | +# the root directory of this source tree. |
| 6 | + |
| 7 | +"""Tests for the classifier reranker type in the search pipeline.""" |
| 8 | + |
| 9 | +from unittest.mock import AsyncMock, MagicMock |
| 10 | + |
| 11 | +import pytest |
| 12 | + |
| 13 | +from ogx.providers.utils.memory.vector_store import ( |
| 14 | + RERANKER_TYPE_CLASSIFIER, |
| 15 | + VectorStoreWithIndex, |
| 16 | +) |
| 17 | +from ogx_api import ChunkMetadata, EmbeddedChunk, QueryChunksResponse |
| 18 | + |
| 19 | + |
| 20 | +def _make_chunk(content: str, chunk_id: str = "c1") -> EmbeddedChunk: |
| 21 | + return EmbeddedChunk( |
| 22 | + content=content, |
| 23 | + chunk_id=chunk_id, |
| 24 | + metadata={"document_id": chunk_id}, |
| 25 | + chunk_metadata=ChunkMetadata(document_id=chunk_id, chunk_id=chunk_id), |
| 26 | + embedding=[0.1, 0.2, 0.3], |
| 27 | + embedding_model="test", |
| 28 | + embedding_dimension=3, |
| 29 | + ) |
| 30 | + |
| 31 | + |
| 32 | +class TestClassifierRerankerConstant: |
| 33 | + def test_classifier_constant_defined(self): |
| 34 | + assert RERANKER_TYPE_CLASSIFIER == "classifier" |
| 35 | + |
| 36 | + |
| 37 | +class TestApplyClassifierRerank: |
| 38 | + @pytest.fixture |
| 39 | + def mock_store(self): |
| 40 | + store = MagicMock(spec=VectorStoreWithIndex) |
| 41 | + store.inference_api = AsyncMock() |
| 42 | + store.vector_stores_config = None |
| 43 | + store.apply_classifier_rerank = VectorStoreWithIndex.apply_classifier_rerank.__get__(store) |
| 44 | + store._extract_chunk_texts = VectorStoreWithIndex._extract_chunk_texts |
| 45 | + return store |
| 46 | + |
| 47 | + async def test_filters_below_confidence_threshold(self, mock_store): |
| 48 | + chunks = [_make_chunk("high quality", "c1"), _make_chunk("low quality", "c2")] |
| 49 | + response = QueryChunksResponse(chunks=chunks, scores=[0.9, 0.3]) |
| 50 | + |
| 51 | + rerank_data = MagicMock() |
| 52 | + rerank_data.data = [ |
| 53 | + MagicMock(index=0, relevance_score=0.85), |
| 54 | + MagicMock(index=1, relevance_score=0.2), |
| 55 | + ] |
| 56 | + mock_store.inference_api.rerank.return_value = rerank_data |
| 57 | + |
| 58 | + result = await mock_store.apply_classifier_rerank( |
| 59 | + "test query", response, 5, {"model": "test-classifier", "confidence_threshold": 0.5} |
| 60 | + ) |
| 61 | + |
| 62 | + assert len(result.chunks) == 1 |
| 63 | + assert result.chunks[0].content == "high quality" |
| 64 | + assert result.scores[0] == 0.85 |
| 65 | + |
| 66 | + async def test_keeps_all_above_threshold(self, mock_store): |
| 67 | + chunks = [_make_chunk("a", "c1"), _make_chunk("b", "c2")] |
| 68 | + response = QueryChunksResponse(chunks=chunks, scores=[0.9, 0.8]) |
| 69 | + |
| 70 | + rerank_data = MagicMock() |
| 71 | + rerank_data.data = [ |
| 72 | + MagicMock(index=0, relevance_score=0.9), |
| 73 | + MagicMock(index=1, relevance_score=0.8), |
| 74 | + ] |
| 75 | + mock_store.inference_api.rerank.return_value = rerank_data |
| 76 | + |
| 77 | + result = await mock_store.apply_classifier_rerank( |
| 78 | + "test query", response, 5, {"model": "test-classifier", "confidence_threshold": 0.1} |
| 79 | + ) |
| 80 | + |
| 81 | + assert len(result.chunks) == 2 |
| 82 | + |
| 83 | + async def test_zero_threshold_keeps_all(self, mock_store): |
| 84 | + chunks = [_make_chunk("a", "c1"), _make_chunk("b", "c2")] |
| 85 | + response = QueryChunksResponse(chunks=chunks, scores=[0.5, 0.1]) |
| 86 | + |
| 87 | + rerank_data = MagicMock() |
| 88 | + rerank_data.data = [ |
| 89 | + MagicMock(index=0, relevance_score=0.5), |
| 90 | + MagicMock(index=1, relevance_score=0.1), |
| 91 | + ] |
| 92 | + mock_store.inference_api.rerank.return_value = rerank_data |
| 93 | + |
| 94 | + result = await mock_store.apply_classifier_rerank( |
| 95 | + "test query", response, 5, {"model": "test-classifier", "confidence_threshold": 0.0} |
| 96 | + ) |
| 97 | + |
| 98 | + assert len(result.chunks) == 2 |
| 99 | + |
| 100 | + async def test_no_model_returns_original(self, mock_store): |
| 101 | + chunks = [_make_chunk("a", "c1")] |
| 102 | + response = QueryChunksResponse(chunks=chunks, scores=[0.5]) |
| 103 | + |
| 104 | + result = await mock_store.apply_classifier_rerank("test query", response, 5, {}) |
| 105 | + |
| 106 | + assert len(result.chunks) == 1 |
| 107 | + mock_store.inference_api.rerank.assert_not_called() |
| 108 | + |
| 109 | + async def test_inference_error_returns_original(self, mock_store): |
| 110 | + chunks = [_make_chunk("a", "c1")] |
| 111 | + response = QueryChunksResponse(chunks=chunks, scores=[0.5]) |
| 112 | + mock_store.inference_api.rerank.side_effect = RuntimeError("model unavailable") |
| 113 | + |
| 114 | + result = await mock_store.apply_classifier_rerank("test query", response, 5, {"model": "bad-model"}) |
| 115 | + |
| 116 | + assert len(result.chunks) == 1 |
| 117 | + assert result.scores[0] == 0.5 |
| 118 | + |
| 119 | + async def test_calls_rerank_with_correct_model(self, mock_store): |
| 120 | + chunks = [_make_chunk("content", "c1")] |
| 121 | + response = QueryChunksResponse(chunks=chunks, scores=[0.5]) |
| 122 | + |
| 123 | + rerank_data = MagicMock() |
| 124 | + rerank_data.data = [MagicMock(index=0, relevance_score=0.9)] |
| 125 | + mock_store.inference_api.rerank.return_value = rerank_data |
| 126 | + |
| 127 | + await mock_store.apply_classifier_rerank("my query", response, 5, {"model": "my-org/quality-classifier"}) |
| 128 | + |
| 129 | + call_args = mock_store.inference_api.rerank.call_args[0][0] |
| 130 | + assert call_args.model == "my-org/quality-classifier" |
| 131 | + assert call_args.query == "my query" |
| 132 | + |
| 133 | + async def test_out_of_bounds_index_ignored(self, mock_store): |
| 134 | + chunks = [_make_chunk("only one", "c1")] |
| 135 | + response = QueryChunksResponse(chunks=chunks, scores=[0.5]) |
| 136 | + |
| 137 | + rerank_data = MagicMock() |
| 138 | + rerank_data.data = [ |
| 139 | + MagicMock(index=0, relevance_score=0.9), |
| 140 | + MagicMock(index=99, relevance_score=0.8), |
| 141 | + ] |
| 142 | + mock_store.inference_api.rerank.return_value = rerank_data |
| 143 | + |
| 144 | + result = await mock_store.apply_classifier_rerank("query", response, 5, {"model": "test-model"}) |
| 145 | + |
| 146 | + assert len(result.chunks) == 1 |
| 147 | + assert result.scores[0] == 0.9 |
| 148 | + |
| 149 | + async def test_all_filtered_returns_empty(self, mock_store): |
| 150 | + chunks = [_make_chunk("low", "c1"), _make_chunk("also low", "c2")] |
| 151 | + response = QueryChunksResponse(chunks=chunks, scores=[0.3, 0.2]) |
| 152 | + |
| 153 | + rerank_data = MagicMock() |
| 154 | + rerank_data.data = [ |
| 155 | + MagicMock(index=0, relevance_score=0.1), |
| 156 | + MagicMock(index=1, relevance_score=0.05), |
| 157 | + ] |
| 158 | + mock_store.inference_api.rerank.return_value = rerank_data |
| 159 | + |
| 160 | + result = await mock_store.apply_classifier_rerank( |
| 161 | + "query", response, 5, {"model": "test-model", "confidence_threshold": 0.5} |
| 162 | + ) |
| 163 | + |
| 164 | + assert len(result.chunks) == 0 |
| 165 | + assert len(result.scores) == 0 |
0 commit comments