Commit 668d7fa
authored
fix: strip inline:: prefix from model in vector io tests (#4993)
Problem -
The vector IO integration tests were using a non-standard model name:
`inline::sentence-transformers/nomic-ai/nomic-embed-text-v1.5`
The vector IO test setup in `conftest.py` and `fixtures/common.py` had
hardcoded the same wrong value, masking the bug — lookups accidentally
matched the incorrectly-prefixed key.
Fix -
**`stack.py`** — use the bare provider type without the
`inline::`/`remote::` namespace as the routing-table key.
**`fixtures/common.py`** — `QualifiedModel.provider_id` is used for a
routing-table lookup; derive it from the bare portion of the
`embedding_model` option string (`"sentence-transformers/model"` →
`"sentence-transformers"`) rather than hardcoding
`"inline::sentence-transformers"`.
Cleanup -
As a side effect, `conftest.py`'s
`parse_vector_io_providers_from_config` (which manually re-parsed the
`--stack-config` string) and an analogous substring check in
`pytest_configure` are replaced with calls to
`run_config_from_adhoc_config_spec`, reading provider IDs directly from
the resulting `StackConfig` instead of duplicating the parsing logic. to
read provider IDs directly.1 parent 3a7306f commit 668d7fa
3 files changed
Lines changed: 22 additions & 45 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
765 | 765 | | |
766 | 766 | | |
767 | 767 | | |
768 | | - | |
| 768 | + | |
769 | 769 | | |
770 | 770 | | |
771 | 771 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
149 | | - | |
150 | | - | |
151 | | - | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
152 | 155 | | |
153 | 156 | | |
154 | 157 | | |
| |||
241 | 244 | | |
242 | 245 | | |
243 | 246 | | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | 247 | | |
267 | 248 | | |
268 | 249 | | |
| |||
272 | 253 | | |
273 | 254 | | |
274 | 255 | | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
283 | 262 | | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
291 | 269 | | |
292 | 270 | | |
293 | 271 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
332 | 331 | | |
333 | 332 | | |
334 | 333 | | |
| |||
0 commit comments