feat(letsgo): add nimble-search to letsgo auto-detection (#6080)

Add remote::nimble-search to the web search provider priority list so it
is auto-detected when NIMBLE_API_KEY is set. Update the corresponding
unit tests to cover the new provider.

Signed-off-by: Matthew Farrellee <matt@cs.wisc.edu>

Author: mattf

src/ogx/cli/stack/lets_go.py

@@ -248,6 +248,7 @@ def _add_file_search_and_responses(run_config: StackConfig) -> None:
         ("remote::brave-search", "brave-search"),
         ("remote::tavily-search", "tavily-search"),
         ("remote::bing-search", "bing-search"),
+        ("remote::nimble-search", "nimble-search"),
     ]
     tool_runtime_registry = get_provider_registry().get(Api.tool_runtime, {})
     existing_web_search: set[str] = {

tests/unit/cli/test_stack_lets_go.py

@@ -557,6 +557,7 @@ def test_uses_brave_when_brave_key_is_set(self, monkeypatch: pytest.MonkeyPatch)
         monkeypatch.setenv("BRAVE_SEARCH_API_KEY", "brave-key")
         monkeypatch.delenv("TAVILY_SEARCH_API_KEY", raising=False)
         monkeypatch.delenv("BING_API_KEY", raising=False)
+        monkeypatch.delenv("NIMBLE_API_KEY", raising=False)
 
         with patch("ogx.cli.stack.lets_go.cprint") as mock_cprint:
             _add_file_search_and_responses(
@@ -571,13 +572,14 @@ def test_uses_brave_when_brave_key_is_set(self, monkeypatch: pytest.MonkeyPatch)
 
         web_search_providers = [
             p
-            for p in ["brave-search", "tavily-search", "bing-search"]
+            for p in ["brave-search", "tavily-search", "bing-search", "nimble-search"]
             if any(p in str(call) for call in mock_cprint.call_args_list)
         ]
         # Only brave should be added (env var set)
         assert "brave-search" in web_search_providers
         assert "tavily-search" not in web_search_providers
         assert "bing-search" not in web_search_providers
+        assert "nimble-search" not in web_search_providers
 
     def test_falls_back_to_tavily_when_only_tavily_key_set(self, monkeypatch: pytest.MonkeyPatch):
         from ogx.cli.stack.lets_go import _add_file_search_and_responses
@@ -586,6 +588,7 @@ def test_falls_back_to_tavily_when_only_tavily_key_set(self, monkeypatch: pytest
         monkeypatch.delenv("BRAVE_SEARCH_API_KEY", raising=False)
         monkeypatch.setenv("TAVILY_SEARCH_API_KEY", "tavily-key")
         monkeypatch.delenv("BING_API_KEY", raising=False)
+        monkeypatch.delenv("NIMBLE_API_KEY", raising=False)
 
         with patch("ogx.cli.stack.lets_go.cprint") as mock_cprint:
             _add_file_search_and_responses(
@@ -606,6 +609,8 @@ def test_falls_back_to_tavily_when_only_tavily_key_set(self, monkeypatch: pytest
                 provider_ids_in_calls.add("tavily-search")
             if "bing-search" in str(call):
                 provider_ids_in_calls.add("bing-search")
+            if "nimble-search" in str(call):
+                provider_ids_in_calls.add("nimble-search")
 
         # Only tavily is added since only its env var is set
         assert provider_ids_in_calls == {"tavily-search"}
@@ -617,6 +622,7 @@ def test_selects_first_with_api_key(self, monkeypatch: pytest.MonkeyPatch):
         monkeypatch.setenv("BRAVE_SEARCH_API_KEY", "brave-key")
         monkeypatch.setenv("TAVILY_SEARCH_API_KEY", "tavily-key")
         monkeypatch.setenv("BING_API_KEY", "bing-key")
+        monkeypatch.setenv("NIMBLE_API_KEY", "nimble-key")
 
         with patch("ogx.cli.stack.lets_go.cprint") as mock_cprint:
             _add_file_search_and_responses(
@@ -637,16 +643,18 @@ def test_selects_first_with_api_key(self, monkeypatch: pytest.MonkeyPatch):
                 provider_ids_in_calls.add("tavily-search")
             if "bing-search" in str(call):
                 provider_ids_in_calls.add("bing-search")
+            if "nimble-search" in str(call):
+                provider_ids_in_calls.add("nimble-search")
 
-        # All three have keys, all three should be added
-        assert provider_ids_in_calls == {"brave-search", "tavily-search", "bing-search"}
+        # All four have keys, all four should be added
+        assert provider_ids_in_calls == {"brave-search", "tavily-search", "bing-search", "nimble-search"}
 
     def test_no_web_search_when_no_key_set(self, monkeypatch: pytest.MonkeyPatch):
         from ogx.cli.stack.lets_go import _add_file_search_and_responses
         from ogx.core.datatypes import StackConfig
 
         # Clear env vars to ensure no keys are set
-        for var in ("BRAVE_SEARCH_API_KEY", "TAVILY_SEARCH_API_KEY", "BING_API_KEY"):
+        for var in ("BRAVE_SEARCH_API_KEY", "TAVILY_SEARCH_API_KEY", "BING_API_KEY", "NIMBLE_API_KEY"):
             monkeypatch.delenv(var, raising=False)
 
         with patch("ogx.cli.stack.lets_go.cprint") as mock_cprint:
@@ -668,7 +676,7 @@ def test_duplicate_providers_when_already_configured(self, monkeypatch: pytest.M
         from ogx.cli.stack.lets_go import _add_file_search_and_responses
         from ogx.core.datatypes import Provider, StackConfig
 
-        for var in ("BRAVE_SEARCH_API_KEY", "TAVILY_SEARCH_API_KEY", "BING_API_KEY"):
+        for var in ("BRAVE_SEARCH_API_KEY", "TAVILY_SEARCH_API_KEY", "BING_API_KEY", "NIMBLE_API_KEY"):
             monkeypatch.delenv(var, raising=False)
 
         initial_providers = [
@@ -690,6 +698,7 @@ def test_duplicate_providers_when_already_configured(self, monkeypatch: pytest.M
             "remote::brave-search",
             "remote::tavily-search",
             "remote::bing-search",
+            "remote::nimble-search",
         }
         web_search_providers = [p for p in config.providers["tool_runtime"] if p.provider_type in web_search_types]
         assert len(web_search_providers) == 1