Skip to content

Commit e18faf3

Browse files
lesebclaude
andcommitted
fix: remove unused sdk_detection module and clarify Google model format
Address review feedback: - Delete sdk_detection.py which became dead code after switching to direct Header() params for SDK detection - Remove sdk_detection from pyproject.toml py-modules since it should not be part of the public API surface - Add comment clarifying that the Google models/{id} format is specific to the Gemini API and Vertex AI would need provider-aware translation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sébastien Han <seb@redhat.com>
1 parent 21387ca commit e18faf3

3 files changed

Lines changed: 2 additions & 45 deletions

File tree

src/llama_stack/core/routing_tables/models.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,8 @@ async def anthropic_list_models(self) -> AnthropicListModelsResponse:
196196
)
197197

198198
async def google_list_models(self) -> GoogleListModelsResponse:
199+
# Uses the Gemini API "models/{id}" format. Vertex AI uses a different
200+
# resource path and would need provider-aware translation if added.
199201
all_models = await self._get_all_models()
200202
google_models = [
201203
GoogleModelInfo(

src/llama_stack_api/pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ py-modules = [
7777
"llama_stack_api.resource",
7878
"llama_stack_api.router_utils",
7979
"llama_stack_api.schema_utils",
80-
"llama_stack_api.sdk_detection",
8180
"llama_stack_api.vector_stores",
8281
"llama_stack_api.version",
8382
"llama_stack_api.validators",

src/llama_stack_api/sdk_detection.py

Lines changed: 0 additions & 44 deletions
This file was deleted.

0 commit comments

Comments
 (0)