Skip to content

Commit bce5345

Browse files
Claudebodhish
andcommitted
Fix inverted pre_activation logic in thank-you workflow
The workflow was activating for core team members instead of community contributors. Changed `is_team_member == 'true'` to `is_team_member != 'true'` in pre_activation job. This fixes the workflow failure where PRs from team members (like #15660 from Jacobjeevan) were incorrectly triggering the thank-you note generator instead of being skipped. Added documentation notes in both .md and .lock.yml files to prevent this issue from being reintroduced during future recompilations with gh-aw. Co-authored-by: bodhish <14979190+bodhish@users.noreply.github.com>
1 parent 1b1db2d commit bce5345

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.github/workflows/thank-you-note.lock.yml

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/thank-you-note.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ safe-outputs:
1515
add-comment:
1616
max: 1
1717
target: "*"
18+
# NOTE: When compiling this workflow with gh-aw, manually verify that the
19+
# pre_activation job's activated output uses != 'true' instead of == 'true'
20+
# to ensure the workflow only runs for NON-team members (community contributors).
21+
# gh-aw v0.42.13 had a bug that inverted this logic.
1822
---
1923

2024
# Thank You Note Generator

0 commit comments

Comments
 (0)