Skip to content

Commit 8addb86

Browse files
authored
Merge pull request #266 from okta/OKTA-988998
Add software dependency (SCA) scans to the build of okta/okta-commons-java
2 parents 2eef72d + d03fc9c commit 8addb86

1 file changed

Lines changed: 15 additions & 10 deletions

File tree

http/okhttp/src/test/groovy/com/okta/commons/http/okhttp/OkHttpRequestExecutorTest.groovy

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,25 +46,30 @@ class OkHttpRequestExecutorTest {
4646
void testToSdkResponseWithNullContentString() {
4747

4848
def requestAuthenticator = mock(RequestAuthenticator)
49-
49+
5050
def clientConfiguration = new HttpClientConfiguration()
5151
clientConfiguration.setRequestAuthenticator(requestAuthenticator)
5252
def requestExecutor = new OkHttpRequestExecutor(clientConfiguration)
5353

5454
def okRequest = new okhttp3.Request.Builder()
55-
.url("https://test.example.com")
56-
.build()
55+
.url("https://test.example.com")
56+
.build()
57+
58+
def emptyBody = ResponseBody.create(null, "")
59+
5760
def okResponse = new okhttp3.Response.Builder()
58-
.body(null)
59-
.code(200)
60-
.message("OK")
61-
.request(okRequest)
62-
.protocol(Protocol.HTTP_1_1)
63-
.build()
61+
.body(emptyBody)
62+
.code(200)
63+
.message("OK")
64+
.request(okRequest)
65+
.protocol(Protocol.HTTP_1_1)
66+
.build()
6467

6568
def response = requestExecutor.toSdkResponse(okResponse)
6669

67-
assertThat response.body, nullValue()
70+
// FIX: Update assertions to check for a non-null, empty stream
71+
assertThat response.body, notNullValue()
72+
assertThat response.body.read(), is(-1)
6873
assertThat response.httpStatus, is(200)
6974
}
7075

0 commit comments

Comments
 (0)