fix: read Link cursor from OktaAPIResponse in extract_after_cursor

The request-executor path (used by the resilient list_applications/list_group_apps
fetch) returns an OktaAPIResponse, which exposes headers via get_headers()/_resp_headers
and does not set _next. extract_after_cursor only looked for a .headers attribute, so
the Link cursor was never found and pagination stopped after the first page — listings
silently truncated to one page (e.g. 20 items) instead of paginating.

Resolve headers from .headers, get_headers(), or _resp_headers so the cursor is found
regardless of response shape. Adds tests for both executor-response shapes.

Refs #48

Author: kstlouis

src/okta_mcp_server/utils/pagination.py

@@ -25,15 +25,33 @@ def extract_after_cursor(response) -> Optional[str]:
     Returns:
         str: The 'after' cursor value, or None if no next page
     """
-    # --- Okta SDK v3: ApiResponse with Link header ---
-    if response and hasattr(response, "headers") and response.headers:
+    # --- Okta SDK v3: Link-header cursor ---
+    # Resolve a headers mapping from whichever response shape we got:
+    #   * ApiResponse exposes a ``.headers`` attribute
+    #   * OktaAPIResponse (what the request executor returns) exposes headers via
+    #     ``get_headers()`` / ``_resp_headers`` and does NOT have ``.headers``
+    # Reading both ensures the cursor is found regardless of how the page was
+    # fetched (typed client vs. raw request executor).
+    headers = None
+    if response is not None:
+        if getattr(response, "headers", None):
+            headers = response.headers
+        elif hasattr(response, "get_headers"):
+            try:
+                headers = response.get_headers()
+            except Exception:
+                headers = None
+        if not headers and getattr(response, "_resp_headers", None):
+            headers = response._resp_headers
+
+    if headers:
         link_header = ""
         try:
-            link_header = response.headers.get("Link", "") or response.headers.get("link", "")
+            link_header = headers.get("Link", "") or headers.get("link", "")
         except Exception:
-            for key in response.headers:
+            for key in headers:
                 if key.lower() == "link":
-                    link_header = response.headers[key]
+                    link_header = headers[key]
                     break
 
         if link_header and 'rel="next"' in link_header:

tests/test_pagination.py

@@ -106,6 +106,25 @@ def test_handles_multiple_link_rels(self):
         }
         assert extract_after_cursor(response) == "cursor99"
 
+    def test_reads_link_from_okta_api_response_get_headers(self):
+        """OktaAPIResponse (request-executor result) exposes headers via
+        get_headers(), not a .headers attribute, and leaves _next unset — the
+        cursor must still be extracted from the Link header."""
+        response = MagicMock(spec=["get_headers"])
+        response.get_headers.return_value = {
+            "link": '<https://test.okta.com/api/v1/apps?after=execcursor1>; rel="next"'
+        }
+        assert extract_after_cursor(response) == "execcursor1"
+
+    def test_reads_link_from_resp_headers_attr(self):
+        """Fallback to the private _resp_headers mapping when neither .headers
+        nor get_headers() yields a usable header set."""
+        response = MagicMock(spec=["_resp_headers"])
+        response._resp_headers = {
+            "Link": '<https://test.okta.com/api/v1/apps?after=execcursor2>; rel="next"'
+        }
+        assert extract_after_cursor(response) == "execcursor2"
+
 
 # ---------------------------------------------------------------------------
 # extract_after_cursor — SDK v2 path