Adding Data Source for okta_admin_role_custom (#2704)

Author: dhiwakar-okta

README.md

@@ -129,7 +129,7 @@ Pull requests with new resources and data sources must include:
 
 - Signed [Okta Individual Contributor License Agreement](https://developer.okta.com/cla/) emailed to `CLA@okta.com`
 - Implemented with the [Terraform Plugin Framework](https://developer.hashicorp.com/terraform/plugin/framework) (not [Terraform Plugin SDKv2](https://developer.hashicorp.com/terraform/plugin/sdkv2) )
-- Make Okta API calls with the [okta-sdk-golang v3](https://github.com/okta/okta-sdk-golang) client
+- Make Okta API calls with the [okta-sdk-golang v6](https://github.com/okta/okta-sdk-golang) client
 - Include [Terraform Plugin Acceptance Tests](https://developer.hashicorp.com/terraform/plugin/sdkv2/testing/acceptance-tests)
 
 Please see the [contribution guidelines](.github/CONTRIBUTING.md) for additional

docs/data-sources/admin_role_custom.md

@@ -0,0 +1,30 @@
+---
+page_title: "Data Source: okta_admin_role_custom"
+description: |-
+  Get a custom admin role from Okta.
+---
+
+# Data Source: okta_admin_role_custom
+
+Use this data source to retrieve a custom admin role from Okta.
+
+## Example Usage
+
+```terraform
+data "okta_admin_role_custom" "example" {
+  id = "<role_id>"
+}
+```
+
+<!-- schema generated by tfplugindocs -->
+## Schema
+
+### Required
+
+- `id` (String) The unique identifier for the custom role. Accepts the role ID or label.
+
+### Read-Only
+
+- `label` (String) The name given to the custom role.
+- `description` (String) A human-readable description of the custom role.
+- `permissions` (Set of String) The permissions that the custom role grants.

examples/data-sources/okta_admin_role_custom/datasource.tf

@@ -0,0 +1,9 @@
+resource "okta_admin_role_custom" "test" {
+  label       = "testAcc_replace_with_uuid"
+  description = "test custom role"
+  permissions = ["okta.apps.assignment.manage"]
+}
+
+data "okta_admin_role_custom" "test" {
+  id = okta_admin_role_custom.test.id
+}

okta/services/idaas/data_source_okta_admin_role_custom.go

@@ -0,0 +1,107 @@
+package idaas
+
+import (
+	"context"
+
+	"github.com/hashicorp/terraform-plugin-framework/datasource"
+	"github.com/hashicorp/terraform-plugin-framework/datasource/schema"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/okta/terraform-provider-okta/okta/config"
+)
+
+var _ datasource.DataSource = &adminRoleCustomDataSource{}
+
+func newAdminRoleCustomDataSource() datasource.DataSource {
+	return &adminRoleCustomDataSource{}
+}
+
+type adminRoleCustomDataSource struct {
+	config *config.Config
+}
+
+type adminRoleCustomDataSourceModel struct {
+	Id          types.String `tfsdk:"id"`
+	Label       types.String `tfsdk:"label"`
+	Description types.String `tfsdk:"description"`
+	Permissions types.Set    `tfsdk:"permissions"`
+}
+
+func (d *adminRoleCustomDataSource) Metadata(ctx context.Context, req datasource.MetadataRequest, resp *datasource.MetadataResponse) {
+	resp.TypeName = req.ProviderTypeName + "_admin_role_custom"
+}
+
+func (d *adminRoleCustomDataSource) Configure(_ context.Context, req datasource.ConfigureRequest, resp *datasource.ConfigureResponse) {
+	d.config = dataSourceConfiguration(req, resp)
+}
+
+func (d *adminRoleCustomDataSource) Schema(ctx context.Context, req datasource.SchemaRequest, resp *datasource.SchemaResponse) {
+	resp.Schema = schema.Schema{
+		Description: "Retrieves a custom admin role from Okta.",
+		Attributes: map[string]schema.Attribute{
+			"id": schema.StringAttribute{
+				Required:    true,
+				Description: "The unique identifier for the custom role. Accepts the role ID or label.",
+			},
+			"label": schema.StringAttribute{
+				Computed:    true,
+				Description: "Unique label for the role.",
+			},
+			"description": schema.StringAttribute{
+				Computed:    true,
+				Description: "Description of the role.",
+			},
+			"permissions": schema.SetAttribute{
+				Computed:    true,
+				ElementType: types.StringType,
+				Description: "Array of permissions that the role grants.",
+			},
+		},
+	}
+}
+
+func (d *adminRoleCustomDataSource) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
+	var data adminRoleCustomDataSourceModel
+
+	resp.Diagnostics.Append(req.Config.Get(ctx, &data)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	client := d.config.OktaIDaaSClient.OktaSDKSupplementClient()
+
+	role, _, err := client.GetCustomRole(ctx, data.Id.ValueString())
+	if err != nil {
+		resp.Diagnostics.AddError(
+			"Error reading custom admin role",
+			"Could not read custom admin role, unexpected error: "+err.Error(),
+		)
+		return
+	}
+
+	data.Id = types.StringValue(role.Id)
+	data.Label = types.StringValue(role.Label)
+	data.Description = types.StringValue(role.Description)
+
+	perms, _, err := client.ListCustomRolePermissions(ctx, role.Id)
+	if err != nil {
+		resp.Diagnostics.AddError(
+			"Error reading custom admin role permissions",
+			"Could not read permissions for custom admin role, unexpected error: "+err.Error(),
+		)
+		return
+	}
+
+	permValues := make([]string, len(perms.Permissions))
+	for i, p := range perms.Permissions {
+		permValues[i] = p.Label
+	}
+
+	permSet, diags := types.SetValueFrom(ctx, types.StringType, permValues)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+	data.Permissions = permSet
+
+	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
+}

okta/services/idaas/data_source_okta_admin_role_custom_test.go

@@ -0,0 +1,35 @@
+package idaas_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/okta/terraform-provider-okta/okta/acctest"
+	"github.com/okta/terraform-provider-okta/okta/resources"
+)
+
+func TestAccDataSourceOktaAdminRoleCustom_read(t *testing.T) {
+	datasourceName := fmt.Sprintf("data.%s.test", resources.OktaIDaaSAdminRoleCustom)
+
+	mgr := newFixtureManager("data-sources", resources.OktaIDaaSAdminRoleCustom, t.Name())
+	config := mgr.GetFixtures("datasource.tf", t)
+
+	acctest.OktaResourceTest(t, resource.TestCase{
+		PreCheck:                 acctest.AccPreCheck(t),
+		ErrorCheck:               testAccErrorChecks(t),
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactoriesForTestAcc(t),
+		Steps: []resource.TestStep{
+			{
+				Config: config,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet(datasourceName, "id"),
+					resource.TestCheckResourceAttr(datasourceName, "label", acctest.BuildResourceName(mgr.Seed)),
+					resource.TestCheckResourceAttr(datasourceName, "description", "test custom role"),
+					resource.TestCheckResourceAttr(datasourceName, "permissions.#", "1"),
+					resource.TestCheckResourceAttr(datasourceName, "permissions.0", "okta.apps.assignment.manage"),
+				),
+			},
+		},
+	})
+}

okta/services/idaas/idaas.go

@@ -155,6 +155,7 @@ func FWProviderDataSources() []func() datasource.DataSource {
 		newAppFederatedClaimDataSource,
 		newPushGroupDataSource,
 		newPushGroupsDataSource,
+		newAdminRoleCustomDataSource,
 	}
 }