adds code to prevent attaching auth policy for service oauth apps (#2403)

Author: aditya-okta

README.md

@@ -18,8 +18,8 @@
 The Terraform Okta provider is a plugin for Terraform that allows for the full lifecycle management of Okta resources.
 This provider is maintained internally by the Okta development team.
 
-### WARNING
-We're working on releasing of the okta-terraform-provider v6.0.0, which will introduce support for managing a broader range of Okta resources beyond just management-related ones. Following that, we'd be deprecating the v5 versions of the okta-terraform-provider.
+> [!CAUTION]
+> We're working on releasing of the okta-terraform-provider v6.0.0, which will introduce support for managing a broader range of Okta resources beyond just management-related ones. Following that, we'd be deprecating the v5 versions of the okta-terraform-provider.
 
 ## Examples
 
@@ -30,6 +30,7 @@ in form of raw markdown files.
 
 # Development Environment Setup
 
+
 The sections below will guide you through the requirements, upgrading, getting started, building with and contributing to
 the Okta Terraform Provider.
 

docs/resources/app_oauth.md

@@ -71,7 +71,7 @@ resource "okta_app_oauth" "example" {
 - `admin_note` (String) Application notes for admins.
 - `app_links_json` (String) Displays specific appLinks for the app. The value for each application link should be boolean.
 - `app_settings_json` (String) Application settings in JSON format
-- `authentication_policy` (String) The ID of the associated app_signon_policy. If this property is removed from the application the default sign-on-policy will be associated with this application. We will be stop attaching authentication_policy for applications of type `SERVICE` in the upcoming release.
+- `authentication_policy` (String) The ID of the associated app_signon_policy. If this property is removed from the application the default sign-on-policy will be associated with this application. From now on, there is no need to attach authentication_policy for applications of type `SERVICE` in the upcoming release.
 - `auto_key_rotation` (Boolean) Requested key rotation mode. If
 				auto_key_rotation isn't specified, the client automatically opts in for Okta's
 				key rotation. You can update this property via the API or via the administrator

okta/services/idaas/resource_okta_app_oauth.go

@@ -401,7 +401,7 @@ other arguments that changed will be applied.`,
 				Type:        schema.TypeString,
 				Optional:    true,
 				Computed:    true,
-				Description: `The ID of the associated app_signon_policy. If this property is removed from the application the default sign-on-policy will be associated with this application. We will be stop attaching authentication_policy for applications of type SERVICE in the upcoming release`,
+				Description: `The ID of the associated app_signon_policy. If this property is removed from the application, the default sign-on-policy will be associated with this application. From now on, there is no need to attach authentication_policy for applications of type SERVICE`,
 			},
 			"jwks_uri": {
 				Type:        schema.TypeString,
@@ -478,9 +478,11 @@ func resourceAppOAuthCreate(ctx context.Context, d *schema.ResourceData, meta in
 	if err != nil {
 		return diag.Errorf("failed to update groups claim for an OAuth application: %v", err)
 	}
-	err = createOrUpdateAuthenticationPolicy(ctx, d, meta, app.Id)
-	if err != nil {
-		return diag.Errorf("failed to set authentication policy for an OAuth application: %v", err)
+	if d.Get("type") != "service" {
+		err = createOrUpdateAuthenticationPolicy(ctx, d, meta, app.Id)
+		if err != nil {
+			return diag.Errorf("failed to set authentication policy for an OAuth application: %v", err)
+		}
 	}
 	return resourceAppOAuthRead(ctx, d, meta)
 }