fix(request_condition): save state before post-create calls

The Create function for okta_request_condition only persisted state
after every API call succeeded. When the initial POST created the
condition but a follow-up call failed (activation when the config sets
status = "ACTIVE", or the priority PATCH), Create returned error
diagnostics without ever calling resp.State.Set, so Terraform recorded
nothing. The condition was left orphaned in Okta as an unmanaged
INACTIVE draft, and the next apply created a duplicate.

Persist the created condition to state immediately after the create
POST succeeds, and refresh the saved state after successful activation,
so a mid-Create failure marks the resource as tainted instead of
orphaning it. State saved during Create is preserved by Terraform even
when error diagnostics are returned.

Fixes #2899

Author: exitcode0

okta/services/governance/resource_request_condition.go

@@ -211,6 +211,23 @@ func (r *requestConditionResource) Create(ctx context.Context, req resource.Crea
 		return
 	}
 
+	// The condition now exists in Okta. Persist it to state immediately so
+	// that a failure in any follow-up call below (activation, priority
+	// update) leaves the resource tracked as tainted instead of orphaned
+	// and unmanaged in Okta. State saved during Create is kept by Terraform
+	// even when error diagnostics are returned. A copy of the plan model is
+	// used so the planned status/priority in `data` stay available to the
+	// follow-up logic below.
+	createdState := data
+	resp.Diagnostics.Append(applyRequestConditionToState(ctx, &createdState, requestConditionResp)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+	resp.Diagnostics.Append(resp.State.Set(ctx, &createdState)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
 	// Activate the condition if status is set to ACTIVE
 	if !data.Status.IsNull() && data.Status.ValueString() == "ACTIVE" {
 		requestConditionResp, _, err = r.OktaGovernanceClient.OktaGovernanceSDKClient().
@@ -224,6 +241,19 @@ func (r *requestConditionResource) Create(ctx context.Context, req resource.Crea
 			)
 			return
 		}
+
+		// Refresh the saved state with the activation result so the recorded
+		// status stays accurate (and Delete deactivates correctly) if the
+		// priority update below fails.
+		createdState = data
+		resp.Diagnostics.Append(applyRequestConditionToState(ctx, &createdState, requestConditionResp)...)
+		if resp.Diagnostics.HasError() {
+			return
+		}
+		resp.Diagnostics.Append(resp.State.Set(ctx, &createdState)...)
+		if resp.Diagnostics.HasError() {
+			return
+		}
 	}
 
 	// The API may ignore the priority field on create and return a default