Consolidating unfunction calls in zsh-abbr

[5A6F65]

zsh-abbr calls unfunction many times to clean up private functions.
While this effectively prevents global namespace pollution, each unfunction invocation adds overhead during plugin initialization.

The following are my first 40 items of XTRACE output after formatting.
I think it can be used as a little reference:

Details

time-consuming    structure
50820 _abbr_init:1> emulate -LR zsh
2196 zsh-abbr.zsh:106> typeset -ga ABBR_REGULAR_ABBREVIATION_GLOB_PREFIXES=( ' ' )
543 .zinit-tmp-subst-off:17> functions[compdef]=$'tlocal opt autol type func delete eval new i ret=0 cmd svc ntlocal -a match mbegin mendntem...
298 zsh-abbr.zsh:1959> unfunction -m _abbr:util_list_item
261 zsh-abbr.zsh:1967> unfunction -m _abbr:util_warn
228 zsh-abbr.zsh:1960> unfunction -m _abbr:util_log_unless_quiet
196 zsh-abbr.zsh:1966> unfunction -m _abbr:util_usage
195 zsh-abbr.zsh:1961> unfunction -m _abbr:util_log_unless_quieter
193 zsh-abbr.zsh:1963> unfunction -m _abbr:util_set_once
191 zsh-abbr.zsh:1962> unfunction -m _abbr:util_print
187 zsh-abbr.zsh:1965> unfunction -m _abbr:util_sync_user
187 zsh-abbr.zsh:1964> unfunction -m _abbr:util_set_to_typed_scope
187 .zinit-tmp-subst-on:28> ZINIT[bkp-compdef]=$'tlocal opt autol type func delete eval new i ret=0 cmd svc ntlocal -a match mbegin mendntemu...
173 zsh-abbr.zsh:1933> unfunction -m _abbr
99 zsh-abbr.zsh:1934> unfunction -m _abbr_init
96 (anon):31> print -r -- $'abbr 'g'='git'nnabbr 'git ad'='git add'nabbr 'git aa'='git add -A%'nabbr 'git au'='git add -u%'nabbr 'git ap'='g...
94 zsh-abbr.zsh:1937> unfunction -m _abbr:clear_session
94 zsh-abbr.zsh:1936> unfunction -m _abbr:add
94 zsh-abbr.zsh:1935> unfunction -m _abbr_warn_deprecation
93 zsh-abbr.zsh:1939> unfunction -m _abbr:expand
93 zsh-abbr.zsh:1938> unfunction -m _abbr:erase
91 zsh-abbr.zsh:1942> unfunction -m _abbr:git
90 zsh-abbr.zsh:1943> unfunction -m _abbr:import_aliases
90 zsh-abbr.zsh:1940> unfunction -m _abbr:expansion
89 zsh-abbr.zsh:1955> unfunction -m _abbr:util_check_command
89 zsh-abbr.zsh:1947> unfunction -m _abbr:list_abbreviations
89 zsh-abbr.zsh:1946> unfunction -m _abbr:list
89 zsh-abbr.zsh:1944> unfunction -m _abbr:import_fish
88 zsh-abbr.zsh:1957> unfunction -m _abbr:util_import_alias
88 zsh-abbr.zsh:1954> unfunction -m _abbr:util_bad_options
88 zsh-abbr.zsh:1945> unfunction -m _abbr:import_git_aliases
88 zsh-abbr.zsh:1941> unfunction -m _abbr:export_aliases
87 zsh-abbr.zsh:1956> unfunction -m _abbr:util_error
87 zsh-abbr.zsh:1953> unfunction -m _abbr:util_alias
87 zsh-abbr.zsh:1948> unfunction -m _abbr:list_commands
86 zsh-abbr.zsh:1952> unfunction -m _abbr:util_add
86 zsh-abbr.zsh:1951> unfunction -m _abbr:rename
86 zsh-abbr.zsh:1950> unfunction -m _abbr:profile
86 zsh-abbr.zsh:1949> unfunction -m _abbr:print_version
85 zsh-abbr.zsh:1958> unfunction -m _abbr:util_list

I don't know the underlying mechanics, but apparently we can replace individual calls with a pattern-based deletion (e.g. unfunction -m "_abbr:*").
This should provide a marginal improvement to initialization speed, and I'd love to know if anyone else can add to this.

[olets]

Haven't experimented with this. If it works, all the functions unfunctioned at the end of zsh-abbr.zsh could be given a shared prefix -

- _abbr:
+ _abbr_internal: # or _abbr_temp:

--

Do you customize either ABBR_REGULAR_ABBREVIATION_SCALAR_PREFIXES or ABBR_REGULAR_ABBREVIATION_GLOB_PREFIXES? Interested to see that

typeset -ga ABBR_REGULAR_ABBREVIATION_GLOB_PREFIXES=( ' ' )

makes your top 40 but

typeset -ga ABBR_REGULAR_ABBREVIATION_SCALAR_PREFIXES=( 'sudo ' )

doesn't.

[olets]

Available for benchmarking in the branch issues/180. The "after" unfunction code is

unfunction -m _abbr
unfunction -m "_abbr*_UNFUNCTIONED"

_abbr is the completion function — forgot I unfunctioned that, and a little surprised that doesn't break completion, but it doesn't so I'll leave it.

[5A6F65]

Do you customize either ABBR_REGULAR_ABBREVIATION_SCALAR_PREFIXES or ABBR_REGULAR_ABBREVIATION_GLOB_PREFIXES? Interested to see that

typeset -ga ABBR_REGULAR_ABBREVIATION_GLOB_PREFIXES=( ' ' )

makes your top 40 but

typeset -ga ABBR_REGULAR_ABBREVIATION_SCALAR_PREFIXES=( 'sudo ' )

doesn't.

I didn't change either of those.
typeset command itself finishes almost instantly.

The time-consuming shown here reflect the interval between the previous and the next command.
There are a large number of function definitions below this line, and I didn't handle this situation correctly.
That was on me. :$

[olets]

The time-consuming shown here reflect the interval between the previous and the next command.
There are a large number of function definitions below this line, and I didn't handle this situation correctly.
That was on me. :$

To clarify: are you saying that ABBR_REGULAR_ABBREVIATION_GLOB_PREFIXES was a false positive, or are you saying that the entire unfunction overhead was a false positive?

//

If you're inspired to benchmark the pattern-based unfunction solution, I've rebased issues/180 with the latest v6.3.3. Of course no pressure.

[5A6F65]

To clarify: are you saying that ABBR_REGULAR_ABBREVIATION_GLOB_PREFIXES was a false positive, or are you saying that the entire unfunction overhead was a false positive?

Of course only ABBR_REGULAR_ABBREVIATION_GLOB_PREFIXES.

---

If you're inspired to benchmark the pattern-based unfunction solution, I've rebased issues/180 with the latest v6.3.3. Of course no pressure.

Thanks for your work!