Initial build setup and question about error (MK_BOOTLOADER_VERSION) - arm gcc changes for newer versions

[cobraPA]

Operating System

Windows 11

INFO_UF2.TXT

None yet, looking to create for new device.

What happened ?

Trying initial builds to learn about the OTAFIX bootloader variant (looking to add another board after confirming local build tree.)

I've pulled newer nRF5 SDK and arm gcc, which look to be setup ok, as initial few files are compiling. Are there any specific build setup requirements for the OTAFIX branch? I didn't see them in the base README.

Now with make I see:

$ make MCU_SUB_VARIANT=nrf52840 BOARD=lilygo_techo all
CC main.c
src/main.c: In function 'main':
: error: invalid suffix 'c0ef40' on integer constant
src/main.c:171:34: note: in expansion of macro 'MK_BOOTLOADER_VERSION'
171 | BOOTLOADER_VERSION_REGISTER = (MK_BOOTLOADER_VERSION);
| ^~~~~~~~~~~~~~~~~~~~~
compilation terminated due to -Wfatal-errors.
make: *** [Makefile:422: _build/build-lilygo_techo/main.o] Error 1

I found a git report for the upstream bootloader that says 'git tags' are required to get the proper MK_BOOTLOADER_VERSION, but this does not seem to pull anything from the OTAFIX branch (see: adafruit#299 )

How to reproduce ?

Probably system specific, so I can provide additional test or info if needed. This is an initial new checkout of latest OTAFIX bootloader so could be setup issue. I did modify the Makefile to add SDK info like so:

(EDIT) -- don't do this, I thought these had to be overridden, but they are local paths --

SDK_PATH = C:/Users/cobra/Documents/Arduino/hardware/Adafruit/Adafruit_nRF52_Bootloader_OTAFIX/lib/sdk/components
SDK11_PATH = C:/Users/cobra/Documents/Arduino/hardware/Adafruit/Adafruit_nRF52_Bootloader_OTAFIX/lib/sdk11/components
TUSB_PATH = C:/Users/cobra/Documents/Arduino/hardware/Adafruit/Adafruit_nRF52_Bootloader_OTAFIX/lib/tinyusb/src
NRFX_PATH = C:/Users/cobra/Documents/Arduino/hardware/Adafruit/Adafruit_nRF52_Bootloader_OTAFIX/lib/nrfx
SD_PATH = C:/Users/cobra/Documents/Arduino/hardware/Adafruit/Adafruit_nRF52_Bootloader_OTAFIX/lib/softdevice/$(SD_FILENAME)

Are there any Makefile.user entries expected? This file didn't exist in the checkout and I have not added it.

Debug Log

No response

Screenshots

No response

[cobraPA]

I see that this would come from tags in your repo. I had made a fork and the default is not to copy tags on github...

I see the value for MK_BOOTLOADER_VERSION comes from:
$ git describe --dirty --always --tags
0c0ef40-dirty

So really, I'm still looking for any other setup required, I am now seeing a build error later:

$ make MCU_SUB_VARIANT=nrf52840 BOARD=lilygo_techo all
CC bootloader_settings.c
lib/sdk11/components/libraries/bootloader_dfu/bootloader_settings.c: In function 'bootloader_mbr_addrs_populate':
lib/sdk11/components/libraries/bootloader_dfu/bootloader_settings.c:45:7: error: array subscript 0 is outside array bounds of 'const uint32_t[0]' {aka 'const long unsigned int[]'} [-Werror=array-bounds=]
45 | if (*(const uint32_t *)MBR_BOOTLOADER_ADDR == 0xFFFFFFFF)
compilation terminated due to -Wfatal-errors.
cc1.exe: all warnings being treated as errors
make: *** [Makefile:433: _build/build-lilygo_techo/bootloader_settings.o] Error 1

[cobraPA]

$ make MCU_SUB_VARIANT=nrf52840 BOARD=lilygo_techo all
CC bootloader_settings.c
lib/sdk11/components/libraries/bootloader_dfu/bootloader_settings.c: In function 'bootloader_mbr_addrs_populate':
lib/sdk11/components/libraries/bootloader_dfu/bootloader_settings.c:45:7: error: array subscript 0 is outside array bounds of 'const uint32_t[0]' {aka 'const long unsigned int[]'} [-Werror=array-bounds=]
45 | if (*(const uint32_t *)MBR_BOOTLOADER_ADDR == 0xFFFFFFFF)
compilation terminated due to -Wfatal-errors.
cc1.exe: all warnings being treated as errors
make: *** [Makefile:433: _build/build-lilygo_techo/bootloader_settings.o] Error 1

This seems to be caused by newer arm gcc and is fixed upstream. They use a block to turn off the check like this:

void bootloader_mbr_addrs_populate(void)
{
#if defined(__GNUC__) && (__GNUC__ >= 12)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Warray-bounds"
#endif
  if (*(const uint32_t *)MBR_BOOTLOADER_ADDR == 0xFFFFFFFF)
  {
    nrfx_nvmc_word_write(MBR_BOOTLOADER_ADDR, BOOTLOADER_REGION_START);
  }
  if (*(const uint32_t *)MBR_PARAM_PAGE_ADDR == 0xFFFFFFFF)
  {
    nrfx_nvmc_word_write(MBR_PARAM_PAGE_ADDR, BOOTLOADER_MBR_PARAMS_PAGE_ADDRESS);
  }
#if defined(__GNUC__) && (__GNUC__ >= 12)
#pragma GCC diagnostic pop
#endif
}

You can also add a general CFLAG parameter of "--param=min-pagesize=0", although you might not want it disabled project wide?

[oltaco]

Yes I think there's a few changes required for building on windows. I have cherry-picked a commit from upstream into the fix-gcc-win branch, do you want to give it a shot?