You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
test(smoke): require field presence, use floors for catalog counts
Two review findings, both fair:
- `field_equals` treated a missing field as an explicit null, so a response that
stopped emitting `all_terms_results` would have passed the boolean-query case.
Presence is checked now: removing the field from the payload fails with
"all_terms_results is missing from the response, expected null".
- pinning the Milano case at exactly 327 matching datasets broke this file's own
rule that thresholds survive catalog drift — my own line from yesterday. Counts
that track the catalog are floors now (`field_min`), while `null` and `0` stay
equalities: they are behaviours, not counts.
Both defects still caught: removing the boolean skip fails with
"all_terms_results is 10, expected null". 16/16.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MEpSWpAwuMaGkfnMpQdqK2
0 commit comments