Merge pull request #309 from onflow/bastian/improve-key-iteration

turbolent · web-flow · commit 2f1cd75ae3a3 · 2026-04-07T13:06:21.000-07:00
Optimize iteration over dictionary keys
diff --git a/cadence/contracts/FlowALPModels.cdc b/cadence/contracts/FlowALPModels.cdc
@@ -553,7 +553,7 @@ access(all) contract FlowALPModels {
             effectiveDebt: {Type: UFix128}
         ) {
             // Enforce single balance per token invariant: if a type appears in one map, it must not appear in the other.
-            for collateralType in effectiveCollateral.keys {
+            for collateralType in effectiveCollateral {
                 assert(effectiveDebt[collateralType] == nil, message: "cannot construct BalanceSheet: observed both credit and debit balance for \(collateralType.identifier)")
             }
 

Original file line number	Diff line number	Diff line change
`@@ -553,7 +553,7 @@ access(all) contract FlowALPModels {`
`553`	`553`	`effectiveDebt: {Type: UFix128}`
`554`	`554`	`) {`
`555`	`555`	`// Enforce single balance per token invariant: if a type appears in one map, it must not appear in the other.`
`556`		`- for collateralType in effectiveCollateral.keys {`
	`556`	`+ for collateralType in effectiveCollateral {`
`557`	`557`	`assert(effectiveDebt[collateralType] == nil, message: "cannot construct BalanceSheet: observed both credit and debit balance for \(collateralType.identifier)")`
`558`	`558`	`}`
`559`	`559`