Skip to content

Commit 4cefe35

Browse files
update contract comments
1 parent cb3785f commit 4cefe35

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

cadence/contracts/TidalProtocol.cdc

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,9 @@ access(all) contract TidalProtocol {
147147
/// An struct containing a position's overview in terms of its effective collateral and debt as well as its
148148
/// current health
149149
access(all) struct BalanceSheet {
150-
/// A position's withdrawable value based on collateral deposits against a Pool's collateral and borrow factors
150+
/// A position's withdrawable value based on collateral deposits against the Pool's collateral and borrow factors
151151
access(all) let effectiveCollateral: UFix64
152-
/// A position's withdrawn value based on withdrawals against a Pool's collateral and borrow factors
152+
/// A position's withdrawn value based on withdrawals against the Pool's collateral and borrow factors
153153
access(all) let effectiveDebt: UFix64
154154
/// The health of the related position
155155
access(all) let health: UFix64
@@ -238,7 +238,7 @@ access(all) contract TidalProtocol {
238238

239239
/// TokenState
240240
///
241-
/// The TokenState struct tracks values related to a single token Type within a Pool.
241+
/// The TokenState struct tracks values related to a single token Type within the Pool.
242242
access(all) struct TokenState {
243243
/// The timestamp at which the TokenState was last updated
244244
access(all) var lastUpdate: UFix64
@@ -351,7 +351,6 @@ access(all) contract TidalProtocol {
351351
///
352352
/// A Pool is the primary logic for protocol operations. It contains the global state of all positions, credit and
353353
/// debit balances for each supported token type, and reserves as they are deposited to positions.
354-
///
355354
access(all) resource Pool {
356355
/// Global state for tracking each token
357356
access(self) var globalLedger: {Type: TokenState}
@@ -1351,13 +1350,13 @@ access(all) contract TidalProtocol {
13511350

13521351
/// PoolFactory
13531352
///
1354-
/// Resource enabling the contract account to create a Pool. This pattern is used in place of contract methods to
1355-
/// ensure limited access to pool creation. While this could be done in contract's init, doing so here will allow
1356-
/// for the setting of the Pool's PriceOracle without the introduction of a concrete PriceOracle defining contract
1357-
/// which would include an external contract dependency.
1353+
/// Resource enabling the contract account to create the contract's Pool. This pattern is used in place of contract
1354+
/// methods to ensure limited access to pool creation. While this could be done in contract's init, doing so here
1355+
/// will allow for the setting of the Pool's PriceOracle without the introduction of a concrete PriceOracle defining
1356+
/// contract which would include an external contract dependency.
13581357
///
13591358
access(all) resource PoolFactory {
1360-
/// Creates a Pool and saves it to the canonical path, reverting if one is already stored
1359+
/// Creates the contract-managed Pool and saves it to the canonical path, reverting if one is already stored
13611360
access(all) fun createPool(defaultToken: Type, priceOracle: {DFB.PriceOracle}) {
13621361
pre {
13631362
TidalProtocol.account.storage.type(at: TidalProtocol.PoolStoragePath) == nil:
@@ -1376,6 +1375,7 @@ access(all) contract TidalProtocol {
13761375
/// A Position is an external object representing ownership of value deposited to the protocol. From a Position, an
13771376
/// actor can deposit and withdraw funds as well as construct DeFiBlocks components enabling value flows in and out
13781377
/// of the Position from within the context of DeFiBlocks stacks.
1378+
///
13791379
// TODO: Consider making this a resource given how critical it is to accessing a loan
13801380
access(all) struct Position {
13811381
/// The unique ID of the Position used to track deposits and withdrawals to the Pool
@@ -1519,7 +1519,6 @@ access(all) contract TidalProtocol {
15191519
///
15201520
/// A DeFiBlocks connector enabling deposits to a Position from within a DeFiBlocks stack. This Sink is intended to
15211521
/// be constructed from a Position object.
1522-
///
15231522
access(all) struct PositionSink: DFB.Sink {
15241523
/// An optional DFB.UniqueIdentifier that identifies this Sink with the DeFiBlocks stack its a part of
15251524
access(contract) let uniqueID: DFB.UniqueIdentifier?

0 commit comments

Comments
 (0)