Skip to content

Commit c6a435c

Browse files
Apply suggestions from code review
Co-authored-by: Jordan Schalm <jordan.schalm@gmail.com> Co-authored-by: Alex <12097569+nialexsan@users.noreply.github.com>
1 parent 717ecae commit c6a435c

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

cadence/contracts/connectors/evm/UniswapV3SwapConnectors.cdc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,14 +285,12 @@ access(all) contract UniswapV3SwapConnectors {
285285

286286
/// Swap exact input -> min output using Uniswap V3 exactInput/Single
287287
access(all) fun swap(quote: {DeFiActions.Quote}?, inVault: @{FungibleToken.Vault}): @{FungibleToken.Vault} {
288-
pre { inVault.getType() == self.inVault: "Input vault type mismatch" }
289288
let minOut = quote?.outAmount ?? self.quoteOut(forProvided: inVault.balance, reverse: false).outAmount
290289
return <- self._swapExactIn(exactVaultIn: <-inVault, amountOutMin: minOut, reverse: false)
291290
}
292291

293292
/// Swap back (exact input of residual -> min output)
294293
access(all) fun swapBack(quote: {DeFiActions.Quote}?, residual: @{FungibleToken.Vault}): @{FungibleToken.Vault} {
295-
pre { residual.getType() == self.outVault: "Residual vault type mismatch" }
296294
let minOut = quote?.outAmount ?? self.quoteOut(forProvided: residual.balance, reverse: true).outAmount
297295
return <- self._swapExactIn(exactVaultIn: <-residual, amountOutMin: minOut, reverse: true)
298296
}

cadence/tests/fork/UniswapV3SwapConnectors_coa_dust_test.cdc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ access(all) fun assertSwapDust(results: [[UFix64]]) {
453453
// --- Swap tests ---------------------------------------------------------------
454454

455455
/// Baseline: MOET → PYUSD swaps produce zero COA dust because PYUSD is a
456-
/// 6-decimal ERC20 (≤8 decimals), so `toCadenceOut` is an exact conversionunicoadu
456+
/// 6-decimal ERC20 (≤8 decimals), so `toCadenceOut` is an exact conversion
457457
/// with no quantum-boundary rounding.
458458
///
459459
access(all) fun testSwapDustStaysInCOA() {

0 commit comments

Comments
 (0)