Skip to content

Review message filtering is too aggressive when using multiple window for the same review #128

Description

@jsonn

The current check in

!this.isPlayerController() ||
fails if the controller of a review has multiple views open. This can be two browser windows, but it could also be a different application and a browser window. Just turning the whole condition into true is a significant improvement and would synchronize two browser windows. Markers don't get synchronized correctly though and it would not be possible to have two different locations. So this issue is a bit about what the expected behavior is from a client perspective:

  1. Only synchronize the move tree and update markers iff they affect the current move
  2. Keep the board state fully synced

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions