chore: remove neverendingsupport dependencies in node package manager (#300)

* remove herodevs

* comment

* Update Dockerfile

Co-authored-by: Stacey Beard <31229509+staceybeard@users.noreply.github.com>

---------

Co-authored-by: Stacey Beard <31229509+staceybeard@users.noreply.github.com>

Author: Douzeyu

.github/actions/build-setup/action.yml

@@ -9,19 +9,11 @@ inputs:
   CONFIG:
     description: 'Contents of the file `config.json` for the given environment'
     required: true
-  NPMRC_FILE:
-    description: 'Secret with the contents of .npmrc'
-    required: true
 
 runs:
   using: "composite"
   steps:
     # Install dependencies
-    - name: Load .npmrc
-      run: echo "${NPMRC_FILE}" > .npmrc
-      shell: bash
-      env:
-        NPMRC_FILE: ${{ inputs.NPMRC_FILE }}
     # Use setup-node's built-in functionality for caching and restoring npm dependencies
     # See: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/caching-dependencies-to-speed-up-workflows
     - uses: actions/setup-node@v4.4.0

.github/workflows/build-and-deploy.yml

@@ -53,7 +53,6 @@ jobs:
         uses: ./.github/actions/build-setup
         with:
           CONFIG: ${{ vars[format('{0}_CONFIG', env.ENVIRONMENT)] }}
-          NPMRC_FILE: ${{ secrets.NPMRC_FILE }}
 
       # Build
       - name: Build the registration website

.github/workflows/ci.yml

@@ -32,7 +32,6 @@ jobs:
         with:
           # No actual config is required, since this job just checks that all dependencies can be installed
           CONFIG: "{}"
-          NPMRC_FILE: ${{ secrets.NPMRC_FILE }}
 
   lint:
     runs-on: ubuntu-latest

.gitlab-ci.yml

@@ -23,9 +23,9 @@ check build:
     # Since this check-build job isn't environment-specific, an empty config file is used
     - echo "{}" > config.json
   script:
-    # add npmrc file with HeroDevs registry token
-    - '[ -z "$NPMRC_FILE" ] && echo "Error: environment variable NPMRC_FILE must be defined for this job" && exit 1'
-    - echo "$NPMRC_FILE" > .npmrc
+    # add npmrc file with HeroDevs registry token, please uncomment the lines below when you have an `npm` token
+    # - '[ -z "$NPMRC_FILE" ] && echo "Error: environment variable NPMRC_FILE must be defined for this job" && exit 1'
+    # - echo "$NPMRC_FILE" > .npmrc
     # Install dependencies and cache within the project directory to cache
     # See: https://javascript.plainenglish.io/improving-ci-performance-aka-how-to-save-your-money-31ff691360e4
     - npm ci --cache .npm --prefer-offline

Dockerfile

@@ -13,7 +13,9 @@ WORKDIR /app
 
 COPY package.json ./
 COPY package-lock.json ./
-COPY .npmrc ./
+
+# uncomment the line below if you have an npm token
+# COPY .npmrc ./
 
 RUN npm ci
 

README.md

@@ -15,16 +15,12 @@ This project contains a `Dockerfile` as well as a `docker-compose.yml` file to r
 In the root directory, copy `config.json.sample` to `config.json`.
 Then add the values for `apiKey` and `databaseURL` to that of your Firebase project.
 
-### Step 2: Add the `.npmrc` file
+### Step 2: Add the `.npmrc` file (Optional)
 
 This project uses [AngularJS](https://angularjs.org/) which reached end of life in January 2022.
-This project uses a long-term support version of AngularJS provided by [HeroDevs](https://www.herodevs.com/support/nes-angularjs).
-If you have an `npm` token to retrieve this version from their registry, place the `.npmrc` file containing the credentials in the root directory.
+A long-term support version of AngularJS can be used instead, provided by [HeroDevs](https://www.herodevs.com/support/nes-angularjs). If you have an `npm` token to retrieve this version from their registry, place the `.npmrc` file containing the credentials in the root directory.
 
-You can also use the [last available version](https://www.npmjs.com/package/angular) of AngularJS (version 1.8.3).
-To do so, change the value for the `angular` dependency in `package.json` to `angular@1.8.3` and run `npm install` to update the lock file.
-
-### Step 2: Start the container
+### Step 3: Start the container
 
 ```shell
 docker compose up

THIRDPARTY.md

@@ -309,7 +309,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 * Homepage: http://angularjs.org
 * Repository: https://github.com/angular/angular.js
-* License: `MIT` (see note below)
+* License: `MIT`
 
 ```text
 The MIT License
@@ -335,10 +335,6 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 ```
 
-### Notes
-
-We use the extended long-term support version provided by HeroDevs (paid service).
-
 ## angular-translate
 
 * Homepage: https://github.com/angular-translate/angular-translate#readme

package-lock.json

@@ -15,7 +15,7 @@
     "@zxcvbn-ts/language-common": "3.0.4",
     "@zxcvbn-ts/language-en": "3.0.2",
     "@zxcvbn-ts/language-fr": "3.0.2",
-    "angular": "npm:@neverendingsupport/angularjs@1.9.10",
+    "angular": "1.8.3",
     "angular-translate": "2.19.1",
     "angular-ui-bootstrap": "2.5.6",
     "angular-ui-router": "1.0.30",

package.json

@@ -24,8 +24,6 @@
   // Ensure that node docker versioning doesn't interfere with the custom managers.
   "ignorePresets": ["workarounds:nodeDockerVersioning"],
   // https://docs.renovatebot.com/getting-started/private-packages/#automatically-authenticate-for-npm-package-stored-in-private-github-npm-repository
-  // The token for the registry it configured via hostRules in the Renovate developer dashboard for the whole organization
-  "npmrc": "@neverendingsupport:registry=https://registry.nes.herodevs.com/npm/pkg/",
   "assignees": ["staceybeard"],
   "labels": ["dependencies"],
   "packageRules": [
@@ -34,10 +32,5 @@
       "matchDatasources": ["docker", "docker-compose"],
       "semanticCommitType": "build"
     },
-    // Group angular-related updates
-    {
-      "matchPackageNames": ["/^angular/"],
-      "groupName": "angular packages"
-    },
   ],
 }