read jobname from flags

Author: mrrr3d

federated-learning-controller/internal/sidecar/README.md

@@ -15,6 +15,7 @@ go run main.go -metricfile <path-to-metric-file> -endpoint <otlp-grpc-endpoint>
   * `-metricfile` (required): The file path for the metrics that the sidecar should watch.
   * `-endpoint` (required): The OTLP/gRPC endpoint of the OpenTelemetry collector (e.g., `localhost:4317`).
   * `-interval` (optional): The interval in seconds for the reporter to automatically push metrics. The default is 60 seconds.
+  * `-jobname` (optional): The name of the job. If not specified, the sidecar will use the default value `federated-learning-obs-sidecar`.
 
 ### Metric File Format
 

federated-learning-controller/internal/sidecar/exporter/exporter.go

@@ -24,7 +24,7 @@ type Reporter struct {
 	callbackRegistration metric.Registration
 }
 
-func NewReporter(ctx context.Context, endpoint string, interval int) (*Reporter, error) {
+func NewReporter(ctx context.Context, endpoint string, interval int, jobName string) (*Reporter, error) {
 	exporter, err := otlpmetricgrpc.New(
 		ctx,
 		otlpmetricgrpc.WithInsecure(),
@@ -41,7 +41,7 @@ func NewReporter(ctx context.Context, endpoint string, interval int) (*Reporter,
 		resource.Default(),
 		resource.NewWithAttributes(
 			semconv.SchemaURL,
-			semconv.ServiceNameKey.String("fl_sidecar"),
+			semconv.ServiceNameKey.String(jobName),
 			semconv.K8SNamespaceNameKey.String(namespace),
 			semconv.K8SPodNameKey.String(podName),
 		),

federated-learning-controller/internal/sidecar/main.go

@@ -17,12 +17,14 @@ var (
 	metricFile       string
 	endpoint         string
 	reporterInterval int
+	jobName          string
 )
 
 func main() {
 	flag.StringVar(&metricFile, "metricfile", "", "Path to the metric file")
 	flag.StringVar(&endpoint, "endpoint", "", "Target endpoint address")
 	flag.IntVar(&reporterInterval, "interval", 60, "Reporter automatic push interval in seconds")
+	flag.StringVar(&jobName, "jobname", "federated-learning-obs-sidecar", "Job name for the metric service")
 	flag.Parse()
 
 	if metricFile == "" || endpoint == "" {
@@ -42,7 +44,7 @@ func main() {
 		cancel()
 	}()
 
-	reporter, err := exporter.NewReporter(ctx, endpoint, reporterInterval)
+	reporter, err := exporter.NewReporter(ctx, endpoint, reporterInterval, jobName)
 	if err != nil {
 		log.Fatalf("Init metrics reporter failed: %v", err)
 	}