Description
The Helm chart's placement.yaml hardcodes global as the ManagedClusterSet in four places (lines 5, 8, 18, 45). While global exists by default on OCM hubs (via the DefaultClusterSet feature gate, which is enabled by default), users who organize clusters into custom ManagedClusterSets cannot use the chart without post-install patching.
Making this value configurable via a Helm value would improve usability without changing the default behavior.
Steps to Reproduce
- helm install dynamic-scoring-framework charts/dynamic-scoring-framework/ on a hub where managed clusters are organized into a custom ManagedClusterSet (not global)
- The Placement selects 0 clusters and the addon agent is not deployed
- User must manually patch both Placements and create a ManagedClusterSetBinding
Suggested Fix
Replace the hardcoded global with a Helm value (e.g., .Values.hubSetting.clusterSet) defaulting to global, so users can override it when needed.
Affected File - charts/dynamic-scoring-framework/templates/placement.yaml — lines 5, 8, 18, 45
Description
The Helm chart's placement.yaml hardcodes global as the ManagedClusterSet in four places (lines 5, 8, 18, 45). While global exists by default on OCM hubs (via the DefaultClusterSet feature gate, which is enabled by default), users who organize clusters into custom ManagedClusterSets cannot use the chart without post-install patching.
Making this value configurable via a Helm value would improve usability without changing the default behavior.
Steps to Reproduce
Suggested Fix
Replace the hardcoded global with a Helm value (e.g., .Values.hubSetting.clusterSet) defaulting to global, so users can override it when needed.
Affected File - charts/dynamic-scoring-framework/templates/placement.yaml — lines 5, 8, 18, 45