Skip to content

Commit 89948df

Browse files
committed
Clarify PlacementRef namespace field requirement
Fix confusing explanation on line 638. The namespace field is required because multiple Placements with the same name can exist in different namespaces, not simply because SubjectMapping is cluster-scoped. The new explanation directly states the reason for requiring the namespace field. Signed-off-by: zhujian <jiazhu@redhat.com>
1 parent ebbc599 commit 89948df

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • enhancements/sig-architecture/233-subject-mapping

enhancements/sig-architecture/233-subject-mapping/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ type PlacementRef struct {
635635
Name string `json:"name"`
636636

637637
// Namespace is the namespace of the Placement resource
638-
// Required since SubjectMapping is cluster-scoped
638+
// Required since multiple Placements with the same name can exist in different namespaces
639639
// +required
640640
// +kubebuilder:validation:MinLength=1
641641
Namespace string `json:"namespace"`

0 commit comments

Comments
 (0)