You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The make generate Makefile target currently doesn't work because of the helmrelease_types.go contains a spec field that has interface{}.
The current workaround is:
Commented out the following 2 lines in helmrelease_types.go
1) Spec HelmAppSpec `json:"spec,omitempty"`
2) type HelmAppSpec interface{} // modified
then run make generate then exclude the helmrelease related changes
It seems like controller-gen used to support interface but not anymore probably due to security reason.
We will need to look into how to modify this field and most importantly maintain backward compatibility.
See some suggestions in https://github.com/kubernetes-sigs/controller-tools/issues/636
To Reproduce
Run make generate
Expected behavior make generate to return successfully.
Additional context
Thank you @TomerFi for discovering and reporting this issue.
Describe the bug
The
make generateMakefile target currently doesn't work because of thehelmrelease_types.gocontains a spec field that hasinterface{}.The current workaround is:
Commented out the following 2 lines in helmrelease_types.go
then run
make generatethen exclude the helmrelease related changesIt seems like controller-gen used to support interface but not anymore probably due to security reason.
We will need to look into how to modify this field and most importantly maintain backward compatibility.
See some suggestions in
https://github.com/kubernetes-sigs/controller-tools/issues/636To Reproduce
Run
make generateExpected behavior
make generateto return successfully.Additional context
Thank you @TomerFi for discovering and reporting this issue.