fix(ui-core): resync staged FilterSelect state on controlled open

Staged selections were only reset inside react-aria's onOpenChange, which
never fires for a programmatic open via the controlled isOpen prop. Move the
resync into an effect on the resolved open state so both paths refresh
staged from selectedValues.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: harsh-vador

openmetadata-ui-core-components/src/main/resources/ui/src/components/application/filter-select/filter-select.test.tsx

@@ -96,6 +96,24 @@ describe('FilterSelect', () => {
     );
   });
 
+  it('resyncs staged selections on a controlled programmatic open', () => {
+    const onChange = vi.fn();
+    const props = {
+      commitMode: 'staged' as const,
+      label: 'Service',
+      options: OPTIONS,
+      onChange,
+    };
+    const { rerender } = render(
+      <FilterSelect {...props} isOpen={false} selectedValues={['redshift']} />
+    );
+
+    rerender(<FilterSelect {...props} isOpen selectedValues={['snowflake']} />);
+    fireEvent.click(screen.getByTestId('apply-filter-btn'));
+
+    expect(onChange).toHaveBeenCalledWith(['snowflake']);
+  });
+
   it('does not commit staged toggles on cancel', () => {
     const { onChange } = renderFilter({ commitMode: 'staged' });
 

openmetadata-ui-core-components/src/main/resources/ui/src/components/application/filter-select/filter-select.tsx

@@ -18,7 +18,7 @@ import { useCoreTranslation } from '@/i18n/useCoreTranslation';
 import { cx } from '@/utils/cx';
 import { borderAfter } from '@/utils/tailwindClasses';
 import { Check, ChevronDown, SearchLg } from '@untitledui/icons';
-import { useMemo, useState, type HTMLAttributes } from 'react';
+import { useEffect, useMemo, useState, type HTMLAttributes } from 'react';
 import { Button as AriaButton, type Selection } from 'react-aria-components';
 import type {
   FilterSelectOption,
@@ -231,13 +231,20 @@ export const FilterSelect = ({
 
   const commit = isStaged ? setStaged : onChange;
 
+  // Resync staged whenever the dropdown transitions open — including a
+  // programmatic open via the controlled `isOpen` prop, which never goes
+  // through react-aria's onOpenChange.
+  useEffect(() => {
+    if (isOpen && isStaged) {
+      setStaged(selectedValues);
+    }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [isOpen]);
+
   const handleOpenChange = (open: boolean) => {
     setInternalOpen(open);
     onOpenChange?.(open);
     setQuery('');
-    if (open) {
-      setStaged(selectedValues);
-    }
   };
 
   const handleSearch = (search: string) => {