Skip to content

Commit 14c8242

Browse files
committed
[receiver/oracledb] Address semconv review: singular units, lock.type, lean descriptions, simpler tests
1 parent 4dc155e commit 14c8242

9 files changed

Lines changed: 130 additions & 129 deletions

File tree

receiver/oracledbreceiver/documentation.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ Fraction of executions that did not require a parse, as computed by Oracle V$SYS
321321
322322
### oracledb.gc.current_block.receive.time
323323
324-
Cumulative time spent receiving current blocks from other instances over Oracle RAC cache fusion, in seconds (converted from centiseconds). The gc prefix here denotes Oracle global cache (Cache Fusion), not JVM garbage collection. Sourced from v$sysstat name gc current block receive time.
324+
Cumulative time spent receiving current blocks from other instances over RAC cache fusion, in seconds.
325325
326326
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
327327
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
@@ -345,7 +345,7 @@ Fraction of library cache pin requests that found the object already cached, as
345345
346346
### oracledb.lock.time
347347
348-
Cumulative time spent on transaction lock activity, in seconds (converted from centiseconds). Sourced from v$sysstat names transaction lock background get time (oracledb.lock.kind=background) and transaction lock foreground wait time (oracledb.lock.kind=foreground).
348+
Cumulative time spent on transaction lock activity, in seconds.
349349
350350
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
351351
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
@@ -355,7 +355,7 @@ Cumulative time spent on transaction lock activity, in seconds (converted from c
355355
356356
| Name | Description | Values | Requirement Level | Semantic Convention |
357357
| ---- | ----------- | ------ | ----------------- | ------------------- |
358-
| oracledb.lock.kind | Whether the lock timing is accumulated by background (get) or foreground (wait) sessions. | Str: ``background``, ``foreground`` | Recommended | - |
358+
| oracledb.lock.type | Whether the lock timing is accumulated by background (get) or foreground (wait) sessions. | Str: ``background``, ``foreground`` | Recommended | - |
359359
360360
### oracledb.logons
361361
@@ -523,11 +523,11 @@ Number of SELECT statements executed in parallel
523523
524524
### oracledb.recovery.blocks_read
525525
526-
Number of blocks read during instance or media recovery. Sourced from v$sysstat name recovery blocks read.
526+
Number of blocks read during instance or media recovery.
527527
528528
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
529529
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
530-
| {blocks} | Sum | Int | Cumulative | true | Development |
530+
| {block} | Sum | Int | Cumulative | true | Development |
531531
532532
### oracledb.recycle_bin.limit
533533
@@ -555,19 +555,19 @@ Fraction of the shared pool that is currently free, as computed by Oracle V$SYSM
555555
556556
### oracledb.smon.instance_recovery.posts
557557
558-
Number of times SMON was posted to perform instance recovery. Sourced from v$sysstat name SMON posted for instance recovery.
558+
Number of times SMON was posted to perform instance recovery.
559559
560560
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
561561
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
562-
| {posts} | Sum | Int | Cumulative | true | Development |
562+
| {post} | Sum | Int | Cumulative | true | Development |
563563
564564
### oracledb.smon.txn_recovery.posts
565565
566-
Number of times SMON was posted to perform transaction recovery for other instances. Sourced from v$sysstat name SMON posted for txn recovery for other instances.
566+
Number of times SMON was posted to perform transaction recovery for other instances.
567567
568568
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
569569
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
570-
| {posts} | Sum | Int | Cumulative | true | Development |
570+
| {post} | Sum | Int | Cumulative | true | Development |
571571
572572
### oracledb.sort.ratio
573573
@@ -624,11 +624,11 @@ Fraction of allocated database storage that is used.
624624
625625
### oracledb.transaction.rollbacks
626626
627-
Number of transactions rolled back. Sourced from v$sysstat name transaction rollbacks. Distinct from oracledb.user_rollbacks (the v$sysstat 'user rollbacks' stat counting user-issued ROLLBACK statements); this counts all transaction rollbacks, including internal/recursive ones.
627+
Number of transactions rolled back.
628628
629629
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
630630
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
631-
| {rollbacks} | Sum | Int | Cumulative | true | Development |
631+
| {rollback} | Sum | Int | Cumulative | true | Development |
632632
633633
## Default Events
634634

receiver/oracledbreceiver/internal/metadata/generated_config.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_config_test.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_metrics.go

Lines changed: 29 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)