fix ListTagsForResource ARN and harden autodiscover tag test

DescribeLogGroups returns two ARN fields for each log group. The Arn field
carries the log-stream wildcard suffix ":*", while LogGroupArn is documented
by the AWS SDK as the value to use for tagging APIs. ListTagsForResource
rejects the ":*" form with a ValidationException, so tag-based autodiscovery
fails at runtime against real AWS despite the unit test passing with a
non-realistic mock ARN.

Switch to lg.LogGroupArn, update the test mock to include both fields, and
tighten the assertion so a log group whose tags do not match is verified to
be excluded from FilterLogEvents rather than only checking that some record
flowed.

Rename the chloggen entry to match the surrounding naming convention.

Author: taiyo2001

.chloggen/main.yaml …ggen/awscloudwatch-tag-filter-46237.yaml.chloggen/main.yaml renamed to .chloggen/awscloudwatch-tag-filter-46237.yaml .chloggen/main.yaml renamed to .chloggen/awscloudwatch-tag-filter-46237.yaml

@@ -462,7 +462,7 @@ func (l *logsReceiver) discoverGroups(ctx context.Context, auto *AutodiscoverCon
 
 			if auto.Tags != nil {
 				tags, err := l.client.ListTagsForResource(ctx, &cloudwatchlogs.ListTagsForResourceInput{
-					ResourceArn: aws.String(*lg.Arn),
+					ResourceArn: lg.LogGroupArn,
 				})
 				if err != nil {
 					l.settings.Logger.Error("unable to list tags for resource", zap.Error(err))

receiver/awscloudwatchreceiver/logs.go

@@ -1003,11 +1003,13 @@ func TestAutodiscoverTags(t *testing.T) {
 	}), mock.Anything).Return(&cloudwatchlogs.DescribeLogGroupsOutput{
 		LogGroups: []types.LogGroup{
 			{
-				Arn:          aws.String("arn:aws:logs:us-west-1:123456789012:log-group:/aws/working-group"),
+				Arn:          aws.String("arn:aws:logs:us-west-1:123456789012:log-group:/aws/working-group:*"),
+				LogGroupArn:  aws.String("arn:aws:logs:us-west-1:123456789012:log-group:/aws/working-group"),
 				LogGroupName: aws.String("/aws/working-group"),
 			},
 			{
-				Arn:          aws.String("arn:aws:logs:us-west-1:123456789012:log-group:/aws/not-in-tags-group"),
+				Arn:          aws.String("arn:aws:logs:us-west-1:123456789012:log-group:/aws/not-in-tags-group:*"),
+				LogGroupArn:  aws.String("arn:aws:logs:us-west-1:123456789012:log-group:/aws/not-in-tags-group"),
 				LogGroupName: aws.String("/aws/not-in-tags-group"),
 			},
 		},
@@ -1047,11 +1049,16 @@ func TestAutodiscoverTags(t *testing.T) {
 	require.NoError(t, err)
 
 	require.Eventually(t, func() bool {
-		return sink.LogRecordCount() > 0
+		return sink.LogRecordCount() >= 1
 	}, 2*time.Second, 10*time.Millisecond)
 
 	err = logsRcvr.Shutdown(t.Context())
 	require.NoError(t, err)
+
+	require.Equal(t, 1, sink.LogRecordCount(), "log group whose tags do not match should be excluded")
+	mc.AssertNotCalled(t, "FilterLogEvents", mock.Anything, mock.MatchedBy(func(input *cloudwatchlogs.FilterLogEventsInput) bool {
+		return input.LogGroupName != nil && *input.LogGroupName == "/aws/not-in-tags-group"
+	}), mock.Anything)
 }
 
 func defaultMockClient() client {