unexport checkpointKey

Author: kangyili

internal/k8sinventory/checkpoint/checkpointer.go

@@ -44,7 +44,7 @@ func (c *Checkpointer) GetCheckpoint(ctx context.Context, namespace, objectType
 		return "", errors.New("storage client is nil")
 	}
 
-	checkPointKey := c.CheckpointKey(namespace, objectType)
+	checkPointKey := c.checkpointKey(namespace, objectType)
 	c.logger.Debug("Retrieving checkpoint, key: "+checkPointKey,
 		zap.String("namespace", namespace),
 		zap.String("objectType", objectType))
@@ -76,7 +76,7 @@ func (c *Checkpointer) SetCheckpoint(
 	_ context.Context,
 	namespace, objectType, resourceVersion string,
 ) error {
-	key := c.CheckpointKey(namespace, objectType)
+	key := c.checkpointKey(namespace, objectType)
 	if key == "" {
 		return fmt.Errorf("checkpoint key is empty: %s, %s", namespace, objectType)
 	}
@@ -182,7 +182,7 @@ func (c *Checkpointer) DeleteCheckpoint(
 		return errors.New("storage client is nil")
 	}
 
-	key := c.CheckpointKey(namespace, objectType)
+	key := c.checkpointKey(namespace, objectType)
 	if key == "" {
 		return fmt.Errorf("checkpoint key is empty: %s, %s", namespace, objectType)
 	}
@@ -198,10 +198,10 @@ func (c *Checkpointer) DeleteCheckpoint(
 	return nil
 }
 
-// CheckpointKey generates a unique storage key
+// checkpointKey generates a unique storage key
 // returns resourceVersion key for global watch stream (without namespace) or
 // per namespace watch stream.
-func (*Checkpointer) CheckpointKey(namespace, objectType string) string {
+func (*Checkpointer) checkpointKey(namespace, objectType string) string {
 	// when watch stream is cluster-wide or cluster-scoped resource (no namespace),
 	// the resource version is persisted per object type only.
 	if namespace == "" {

internal/k8sinventory/checkpoint/checkpointer_test.go

@@ -91,7 +91,7 @@ func TestCheckpointerKeyFormat(t *testing.T) {
 			require.NoError(t, err)
 			assert.Equal(t, tt.resourceVersion, rv)
 
-			key := checkpointer.CheckpointKey(tt.namespace, tt.objectType)
+			key := checkpointer.checkpointKey(tt.namespace, tt.objectType)
 			assert.Equal(t, tt.expectedKey, key)
 		})
 	}
@@ -357,7 +357,7 @@ func TestCheckpointerLoadSkipsMissingAndUnparseable(t *testing.T) {
 	// going around SetCheckpoint's validation — write the raw bytes directly.
 	require.NoError(t, cp.SetCheckpoint(ctx, "default", "pods", "100"))
 	require.NoError(t, cp.Flush(ctx))
-	require.NoError(t, client.Set(ctx, cp.CheckpointKey("weird", "pods"), []byte("not-a-number")))
+	require.NoError(t, client.Set(ctx, cp.checkpointKey("weird", "pods"), []byte("not-a-number")))
 
 	cp.Load(ctx, []string{"default", "missing", "weird"}, "pods")
 

internal/k8sinventory/watch/observer_test.go

@@ -841,10 +841,6 @@ func TestObserverPersistenceClusterWideWatch(t *testing.T) {
 	rv, err := checkpointer.GetCheckpoint(t.Context(), "", "pods")
 	require.NoError(t, err)
 	assert.NotEmpty(t, rv) // Should have a value
-
-	// Verify key format
-	key := checkpointer.CheckpointKey("", "pods")
-	assert.Equal(t, "latestResourceVersion/pods", key)
 }
 
 func TestObserverPersistenceMultipleNamespaces(t *testing.T) {
@@ -907,13 +903,6 @@ func TestObserverPersistenceMultipleNamespaces(t *testing.T) {
 	rv2, err := checkpointer.GetCheckpoint(t.Context(), "other", "pods")
 	require.NoError(t, err)
 	assert.Equal(t, "200", rv2)
-
-	// Verify key formats
-	key1 := checkpointer.CheckpointKey("default", "pods")
-	assert.Equal(t, "latestResourceVersion/pods.default", key1)
-
-	key2 := checkpointer.CheckpointKey("other", "pods")
-	assert.Equal(t, "latestResourceVersion/pods.other", key2)
 }
 
 func TestGetResourceVersion(t *testing.T) {