Commit 42a171e
[extension/opampextension] fix self-reported status events being dropped by non-Reporter hosts
opampAgent.Start wired its internal reportFunc to call
componentstatus.ReportStatus(host, event) directly. That helper silently
no-ops when the component.Host passed to Start does not implement
componentstatus.Reporter, so self-reported status changes -- most notably
the fatal error monitorPPID emits when the collector's parent process
disappears -- never reached the extension's own status aggregator. The
collector could keep reporting healthy despite being orphaned.
Track the extension's own component.ID (added extensionID field, set from
extension.Settings.ID in newOpampAgent) and route self-reported events
through the extension's own ComponentStatusChanged handler instead, which
always forwards to the status aggregator regardless of what the host
implements.
Adds TestReportFuncReachesStatusAggregatorRegardlessOfHostReporter, which
starts the agent against componenttest.NewNopHost() (which intentionally
does not implement componentstatus.Reporter) and asserts a fatal error
event reported via o.reportFunc still reaches the mock status aggregator.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 5f5ec54 commit 42a171e
3 files changed
Lines changed: 71 additions & 1 deletion
File tree
- .chloggen
- extension/opampextension
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
106 | 107 | | |
107 | 108 | | |
108 | 109 | | |
| 110 | + | |
109 | 111 | | |
110 | | - | |
| 112 | + | |
111 | 113 | | |
112 | 114 | | |
113 | 115 | | |
| |||
332 | 334 | | |
333 | 335 | | |
334 | 336 | | |
| 337 | + | |
335 | 338 | | |
336 | 339 | | |
337 | 340 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
270 | 308 | | |
271 | 309 | | |
272 | 310 | | |
| |||
0 commit comments