Skip to content

Commit 4595ed1

Browse files
committed
[receiver/oracledb] Drop oracledb.process.cpu.time (source v$sysstat OS CPU stats are always 0)
OS System/User time used require timed_os_statistics (off by default, expensive, unsettable on RDS, absent on Windows) and read 0 even under load on 19c/Linux. DB CPU is already covered by oracledb.cpu_time; host CPU is V$OSSTAT (#48459).
1 parent dff3b8e commit 4595ed1

11 files changed

Lines changed: 3 additions & 330 deletions

.chloggen/feat_add-oracledb-session-jvm-os-metrics.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ issues: [49065]
1818
subtext: |
1919
Adds oracledb.session.waits and oracledb.session.wait.time (attribute oracledb.session.wait.state),
2020
oracledb.session.stored_procedure.usage, oracledb.jvm.memory.used, oracledb.jvm.memory.committed,
21-
oracledb.jvm.memory.live, oracledb.process.cpu.time (attribute cpu.mode), and oracledb.os.swaps.
22-
All are disabled by default and add no new database queries.
21+
oracledb.jvm.memory.live, and oracledb.os.swaps. All are disabled by default and add no new
22+
database queries.
2323
2424
# If your change doesn't affect end users or the exported elements of any package,
2525
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.

receiver/oracledbreceiver/documentation.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -523,20 +523,6 @@ Number of writes directly to disk, bypassing the buffer cache
523523
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
524524
| {writes} | Sum | Int | Cumulative | true | Development |
525525
526-
### oracledb.process.cpu.time
527-
528-
Cumulative CPU time consumed by the Oracle server and background processes, in seconds (converted from centiseconds), as accounted by Oracle. Sourced from v$sysstat names OS System time used (cpu.mode=system) and OS User time used (cpu.mode=user). Mirrors semconv process.cpu.time; reported from Oracle's own process accounting rather than a host/process collector.
529-
530-
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
531-
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
532-
| s | Sum | Double | Cumulative | true | Development |
533-
534-
#### Attributes
535-
536-
| Name | Description | Values | Requirement Level | Semantic Convention |
537-
| ---- | ----------- | ------ | ----------------- | ------------------- |
538-
| cpu.mode | The mode in which the CPU time was consumed, as accounted by Oracle. | Str: ``system``, ``user`` | Recommended | - |
539-
540526
### oracledb.queries_parallelized
541527
542528
Number of SELECT statements executed in parallel

receiver/oracledbreceiver/internal/metadata/config.schema.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -313,13 +313,6 @@ $defs:
313313
enabled:
314314
type: boolean
315315
default: false
316-
oracledb.process.cpu.time:
317-
description: "OracledbProcessCPUTimeMetricConfig provides config for the oracledb.process.cpu.time metric."
318-
type: object
319-
properties:
320-
enabled:
321-
type: boolean
322-
default: false
323316
oracledb.processes.limit:
324317
description: "OracledbProcessesLimitMetricConfig provides config for the oracledb.processes.limit metric."
325318
type: object

receiver/oracledbreceiver/internal/metadata/generated_config.go

Lines changed: 0 additions & 54 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_config_test.go

Lines changed: 1 addition & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)