changes

Author: ebrdarSplunk

.chloggen/sqlserver-server-resource-attributes.yaml

@@ -0,0 +1,32 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
+component: receiver/sqlserver
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Enable the `server.address` and `server.port` resource attributes by default, set `host.name` to the collector host's `os.Hostname()`, and remove the `receiver.sqlserver.RemoveServerResourceAttribute` feature gate.
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [49885]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: |
+  `server.address` and `server.port` are now emitted by default. `host.name` now reports the hostname of the
+  machine running the collector (via `os.Hostname()`) instead of the configured SQL Server address. To stop
+  emitting the server attributes, disable them via `resource_attributes.server.address.enabled: false` and
+  `resource_attributes.server.port.enabled: false`. The `receiver.sqlserver.RemoveServerResourceAttribute`
+  feature gate has been removed.
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []

receiver/sqlserverreceiver/README.md

@@ -157,16 +157,6 @@ Top query collection enabled:
           max_rows_per_query: 1450
 ```
 
-## Feature Gate
-
-A new feature gate was added in `v0.129.0` for removing the `server.address` and `server.port` 
-resource attributes, as they are not identified as resources attributes in the semantic conventions.
-To enable it, pass the following argument to the Collector:
-
-```
---feature-gates=receiver.sqlserver.RemoveServerResourceAttribute
-```
-
 ## Metrics
 
 Details about the metrics produced by this receiver can be found in [documentation.md](./documentation.md)

receiver/sqlserverreceiver/documentation.md

@@ -1267,22 +1267,12 @@ top query
 
 | Name | Description | Values | Enabled | Semantic Convention | Stability |
 | ---- | ----------- | ------ | ------- | ------------------- | --------- |
-| host.name | The host name of SQL Server | Any Str | true | - | - |
-| server.address | Name of the database host. | Any Str | false | - | - |
-| server.port | Server port number. | Any Int | false | - | - |
+| host.name | The hostname of the machine running the collector. | Any Str | true | - | - |
+| server.address | The address of the SQL Server host. | Any Str | true | - | - |
+| server.port | The port of the SQL Server host. | Any Int | true | - | - |
 | service.instance.id | A unique identifier of the SQL Server instance in the format host:port. This resource attribute is only available when the receiver is configured to directly connect to SQL Server. | Any Str | true | - | - |
 | service.name | Logical name of the service. When enabled, defaults to unknown_service:microsoft.sql_server. | Any Str | false | - | - |
 | service.namespace | Logical namespace for the service (for example team or environment). When enabled, defaults to an empty string until set via configuration. | Any Str | false | - | - |
 | sqlserver.computer.name | The name of the SQL Server instance being monitored. | Any Str | false | - | - |
 | sqlserver.database.name | The name of the SQL Server database. | Any Str | true | - | - |
 | sqlserver.instance.name | The name of the SQL Server instance being monitored. | Any Str | false | - | - |
-
-## Feature Gates
-
-This component has the following feature gates:
-
-| Feature Gate | Stage | Description | From Version | To Version | Reference |
-| ------------ | ----- | ----------- | ------------ | ---------- | --------- |
-| `receiver.sqlserver.RemoveServerResourceAttribute` | alpha | When enabled, the server.address and server.port resource attributes are removed from metrics. | v0.129.0 | N/A | [Link](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/40141) |
-
-For more information about feature gates, see the [Feature Gates](https://github.com/open-telemetry/opentelemetry-collector/blob/main/featuregate/README.md) documentation.