Skip to content

Commit 657a8a2

Browse files
committed
fix comment
1 parent 323090d commit 657a8a2

14 files changed

Lines changed: 293 additions & 72 deletions

receiver/sqlserverreceiver/documentation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ This metric is only available when the receiver is configured to directly connec
531531
| Name | Description | Values | Requirement Level | Semantic Convention |
532532
| ---- | ----------- | ------ | ----------------- | ------------------- |
533533
| disk.io.direction | The direction of disk I/O operations. | Str: ``read``, ``write`` | Recommended | - |
534-
| system.filesystem.drive | The drive prefix of the database file path. | Any Str | Recommended | - |
534+
| sqlserver.file.path.prefix | The path prefix identifying the storage location of SQL Server database files. | Any Str | Recommended | - |
535535
536536
### sqlserver.disk.operations
537537
@@ -548,7 +548,7 @@ This metric is only available when the receiver is configured to directly connec
548548
| Name | Description | Values | Requirement Level | Semantic Convention |
549549
| ---- | ----------- | ------ | ----------------- | ------------------- |
550550
| disk.io.direction | The direction of disk I/O operations. | Str: ``read``, ``write`` | Recommended | - |
551-
| system.filesystem.drive | The drive prefix of the database file path. | Any Str | Recommended | - |
551+
| sqlserver.file.path.prefix | The path prefix identifying the storage location of SQL Server database files. | Any Str | Recommended | - |
552552
553553
### sqlserver.error.rate
554554

receiver/sqlserverreceiver/internal/metadata/generated_config.go

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/sqlserverreceiver/internal/metadata/generated_config_test.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/sqlserverreceiver/internal/metadata/generated_metrics.go

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/sqlserverreceiver/internal/metadata/generated_metrics_test.go

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/sqlserverreceiver/internal/metadata/testdata/config.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@ all_set:
6666
enabled: true
6767
sqlserver.disk.io:
6868
enabled: true
69-
attributes: ["disk.io.direction","system.filesystem.drive"]
69+
attributes: ["disk.io.direction","sqlserver.file.path.prefix"]
7070
sqlserver.disk.operations:
7171
enabled: true
72-
attributes: ["disk.io.direction","system.filesystem.drive"]
72+
attributes: ["disk.io.direction","sqlserver.file.path.prefix"]
7373
sqlserver.error.rate:
7474
enabled: true
7575
sqlserver.extent.operation.rate:
@@ -584,10 +584,10 @@ none_set:
584584
enabled: false
585585
sqlserver.disk.io:
586586
enabled: false
587-
attributes: ["disk.io.direction","system.filesystem.drive"]
587+
attributes: ["disk.io.direction","sqlserver.file.path.prefix"]
588588
sqlserver.disk.operations:
589589
enabled: false
590-
attributes: ["disk.io.direction","system.filesystem.drive"]
590+
attributes: ["disk.io.direction","sqlserver.file.path.prefix"]
591591
sqlserver.error.rate:
592592
enabled: false
593593
sqlserver.extent.operation.rate:

receiver/sqlserverreceiver/metadata.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,10 @@ attributes:
223223
type: string
224224
requirement_level: required
225225
enum: [allocated, deallocated]
226+
sqlserver.file.path.prefix:
227+
description: The path prefix identifying the storage location of SQL Server database files.
228+
type: string
229+
requirement_level: recommended
226230
sqlserver.index.id:
227231
description: The identifier of the index.
228232
type: int
@@ -411,10 +415,6 @@ attributes:
411415
description: Number of writes performed by the query.
412416
type: int
413417
requirement_level: recommended
414-
system.filesystem.drive:
415-
description: The drive prefix of the database file path.
416-
type: string
417-
requirement_level: recommended
418418
system.memory.state:
419419
description: The state of the physical memory on the host.
420420
type: string
@@ -794,7 +794,7 @@ metrics:
794794
monotonic: true
795795
aggregation_temporality: cumulative
796796
value_type: int
797-
attributes: [disk.io.direction, system.filesystem.drive]
797+
attributes: [disk.io.direction, sqlserver.file.path.prefix]
798798
extended_documentation: This metric is only available when the receiver is configured to directly connect to SQL Server. Only covers I/O for SQL Server database files, not total host disk I/O.
799799
sqlserver.disk.operations:
800800
enabled: false
@@ -805,7 +805,7 @@ metrics:
805805
monotonic: true
806806
aggregation_temporality: cumulative
807807
value_type: int
808-
attributes: [disk.io.direction, system.filesystem.drive]
808+
attributes: [disk.io.direction, sqlserver.file.path.prefix]
809809
extended_documentation: This metric is only available when the receiver is configured to directly connect to SQL Server. Only covers I/O for SQL Server database files, not total host disk I/O.
810810
sqlserver.error.rate:
811811
enabled: false

0 commit comments

Comments
 (0)