[receiver/pprof] set instrumentation scope name (#49353)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
The `receiver/pprof` component builds ScopeProfiles, but it's apparently
leaving the `scope name` empty. So when profiles flow out of this
receiver, there's no producer identity information and makes it harder
to determine the source of translated profile data.

fix was simple adding the `sp.Scope().SetName(scopeName)` to the
`/pkg/translator/pprof/pprof_to_profiles.go`. Same as done in other
translator packages like `translator/azure`.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
Fixes #49209

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added assertions verifying that converted profiles now include the
expected instrumentation scope name
(`github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/pprof`).
Existing profile conversion tests were updated to validate the scope
metadata in addition to profile content.

<!--Describe the documentation added.-->
#### Documentation
No documentation changes required

<!--Authorship attestation. See AGENTS.md for details. AI agents must
not check this box on behalf
of the user; the human author must check it themselves before the PR is
ready for review.-->
#### Authorship

- [x] I, a human, wrote this pull request description myself.

<!--Please delete paragraphs that you did not use before submitting.-->

Author: avy252004

.chloggen/fix_pprof-instrumentation-scope.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
+component: receiver/pprof
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Set instrumentation scope name and version on pprof profiles based on the scraper mode (file, http client, http server, self).
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [49209]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: Each scraper now sets the instrumentation scope name using the receiver's ScopeName and a per-mode suffix, and the scope version from BuildInfo.The translator function is unchanged.
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

pkg/translator/pprof/pprof_to_profiles.go

@@ -127,7 +127,6 @@ func ConvertPprofToProfiles(src *profile.Profile) (*pprofile.Profiles, error) {
 
 	sp := rp.ScopeProfiles().AppendEmpty()
 	sp.SetSchemaUrl(semconv.SchemaURL)
-
 	// Use a dedicated pprofile.Profile for each sample type.
 	// By convention, pprof uses the last sample type as default, while OTel Profiles
 	// uses the first profile as default. Therefore, swap first and last.

receiver/pprofreceiver/internal/file_scraper.go

@@ -10,17 +10,20 @@ import (
 
 	"github.com/bmatcuk/doublestar/v4"
 	"github.com/google/pprof/profile"
+	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/pdata/pprofile"
 	"go.opentelemetry.io/collector/scraper/scrapererror"
 	"go.uber.org/multierr"
 	"go.uber.org/zap"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/pprof"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/pprofreceiver/internal/metadata"
 )
 
 type FileScraper struct {
-	Include string
-	Logger  *zap.Logger
+	Include   string
+	Logger    *zap.Logger
+	BuildInfo component.BuildInfo
 }
 
 func (fs FileScraper) Scrape(_ context.Context) (pprofile.Profiles, error) {
@@ -52,6 +55,16 @@ func (fs FileScraper) Scrape(_ context.Context) (pprofile.Profiles, error) {
 			continue
 		}
 
+		// set ScopeName and Version
+		for i := 0; i < profiles.ResourceProfiles().Len(); i++ {
+			rp := profiles.ResourceProfiles().At(i)
+			for j := 0; j < rp.ScopeProfiles().Len(); j++ {
+				sp := rp.ScopeProfiles().At(j)
+				sp.Scope().SetName(metadata.ScopeName + "/filescraper")
+				sp.Scope().SetVersion(fs.BuildInfo.Version)
+			}
+		}
+
 		if err := profiles.MergeTo(result); err != nil {
 			scrapeErrors = append(scrapeErrors, fmt.Errorf("failed to merge profiles from %s: %w", match, err))
 			continue

receiver/pprofreceiver/internal/file_scraper_test.go

@@ -9,7 +9,10 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"go.opentelemetry.io/collector/component"
 	"go.uber.org/zap"
+
+	"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/pprofreceiver/internal/metadata"
 )
 
 func TestScrapeFile(t *testing.T) {
@@ -48,3 +51,28 @@ func TestScrapeMultipleFilesMergesDictionaries(t *testing.T) {
 	assert.True(t, strings["beta.go"], "merged dictionary missing string from second file")
 	assert.True(t, strings["inuse_objects"], "merged dictionary missing string from first file")
 }
+
+func TestScrapeFile_SetsScopeName(t *testing.T) {
+	s := FileScraper{
+		Logger: zap.NewNop(),
+		Include: filepath.Join(
+			"testdata",
+			"pprof.otelcol.alloc_objects.alloc_space.inuse_objects.inuse_space.001.pb.gz",
+		),
+		BuildInfo: component.BuildInfo{Version: "1.2.3"},
+	}
+
+	p, err := s.Scrape(t.Context())
+	require.NoError(t, err)
+	require.Positive(t, p.ProfileCount())
+
+	rp := p.ResourceProfiles().At(0)
+	sp := rp.ScopeProfiles().At(0)
+
+	assert.Equal(
+		t,
+		metadata.ScopeName+"/filescraper",
+		sp.Scope().Name(),
+	)
+	require.Equal(t, "1.2.3", sp.Scope().Version())
+}

receiver/pprofreceiver/internal/http_scraper.go

@@ -16,13 +16,15 @@ import (
 	"go.uber.org/zap"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/pprof"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/pprofreceiver/internal/metadata"
 )
 
 var _ xscraper.Profiles = &HTTPClientScraper{}
 
 type HTTPClientScraper struct {
 	ClientConfig confighttp.ClientConfig
 	Settings     component.TelemetrySettings
+	BuildInfo    component.BuildInfo
 	client       *http.Client
 }
 
@@ -56,5 +58,19 @@ func (hcs *HTTPClientScraper) ScrapeProfiles(_ context.Context) (pprofile.Profil
 	if err != nil {
 		return pprofile.Profiles{}, fmt.Errorf("failed to convert pprof to profiles: %w", err)
 	}
+
+	// set ScopeName and Version
+	name := metadata.ScopeName + "/httpclientscraper"
+	version := hcs.BuildInfo.Version
+
+	for i := 0; i < profiles.ResourceProfiles().Len(); i++ {
+		rp := profiles.ResourceProfiles().At(i)
+		for j := 0; j < rp.ScopeProfiles().Len(); j++ {
+			sp := rp.ScopeProfiles().At(j)
+			sp.Scope().SetName(name)
+			sp.Scope().SetVersion(version)
+		}
+	}
+
 	return *profiles, err
 }

receiver/pprofreceiver/internal/http_scraper_test.go

@@ -14,8 +14,11 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/require"
+	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/component/componenttest"
 	"go.opentelemetry.io/collector/config/confighttp"
+
+	"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/pprofreceiver/internal/metadata"
 )
 
 func TestHttpScraper(t *testing.T) {
@@ -37,6 +40,7 @@ func TestHttpScraper(t *testing.T) {
 
 	s := HTTPClientScraper{
 		ClientConfig: confighttp.NewDefaultClientConfig(),
+		BuildInfo:    component.BuildInfo{Version: "1.2.3"},
 	}
 	s.ClientConfig.Endpoint = fmt.Sprintf("http://%s/debug/pprof/", listener.Addr().String())
 	err = s.Start(t.Context(), componenttest.NewNopHost())
@@ -47,4 +51,12 @@ func TestHttpScraper(t *testing.T) {
 	p, err := s.ScrapeProfiles(t.Context())
 	require.NoError(t, err)
 	require.NotEqual(t, 0, p.ProfileCount())
+	sp := p.ResourceProfiles().At(0).ScopeProfiles().At(0)
+
+	require.Equal(
+		t,
+		metadata.ScopeName+"/httpclientscraper",
+		sp.Scope().Name(),
+	)
+	require.Equal(t, "1.2.3", sp.Scope().Version())
 }

receiver/pprofreceiver/internal/http_server.go

@@ -20,6 +20,7 @@ import (
 	"go.uber.org/zap"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/pprof"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/pprofreceiver/internal/metadata"
 )
 
 // PushPath is the path the pprof push server listens on.
@@ -105,6 +106,18 @@ func (s *HTTPServer) handlePush(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	// set ScopeName and Version
+	for i := 0; i < profiles.ResourceProfiles().Len(); i++ {
+		rp := profiles.ResourceProfiles().At(i)
+		for j := 0; j < rp.ScopeProfiles().Len(); j++ {
+			sp := rp.ScopeProfiles().At(j)
+
+			// Directly setting values without any extra initialization
+			sp.Scope().SetName(metadata.ScopeName + "/httpserver")
+			sp.Scope().SetVersion(s.Settings.BuildInfo.Version)
+		}
+	}
+
 	ctx := r.Context()
 	if s.obsrep != nil {
 		ctx = s.obsrep.StartProfilesOp(ctx)

receiver/pprofreceiver/internal/http_server_test.go

@@ -76,6 +76,10 @@ func TestHTTPServerPush(t *testing.T) {
 	resp.Body.Close()
 	assert.Equal(t, http.StatusNoContent, resp.StatusCode)
 	assert.NotEmpty(t, sink.AllProfiles(), "expected profiles to be consumed")
+	profiles := sink.AllProfiles()
+	sp := profiles[0].ResourceProfiles().At(0).ScopeProfiles().At(0)
+	assert.Equal(t, metadata.ScopeName+"/httpserver", sp.Scope().Name())
+	assert.Equal(t, "latest", sp.Scope().Version())
 
 	// invalid body returns 400
 	resp = doRequest(http.MethodPost, []byte("not pprof"))

receiver/pprofreceiver/internal/self_scraper.go

@@ -16,13 +16,15 @@ import (
 	"go.opentelemetry.io/collector/scraper/xscraper"
 
 	translator "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/pprof"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/pprofreceiver/internal/metadata"
 )
 
 var _ xscraper.Profiles = &SelfScraper{}
 
 type SelfScraper struct {
 	BlockProfileFraction int
 	MutexProfileFraction int
+	BuildInfo            component.BuildInfo
 	buf                  *bytes.Buffer
 	writer               *bufio.Writer
 }
@@ -48,6 +50,20 @@ func (hcs *SelfScraper) ScrapeProfiles(_ context.Context) (pprofile.Profiles, er
 	hcs.buf.Reset()
 	if parseErr == nil {
 		p, err := translator.ConvertPprofToProfiles(pprofProfile)
+
+		if p != nil {
+			name := metadata.ScopeName + "/selfscraper"
+			version := hcs.BuildInfo.Version
+			for i := 0; i < p.ResourceProfiles().Len(); i++ {
+				rp := p.ResourceProfiles().At(i)
+				for j := 0; j < rp.ScopeProfiles().Len(); j++ {
+					sp := rp.ScopeProfiles().At(j)
+					sp.Scope().SetName(name)
+					sp.Scope().SetVersion(version)
+				}
+			}
+		}
+
 		_ = pprof.StartCPUProfile(hcs.writer)
 		if p == nil {
 			return pprofile.Profiles{}, err

receiver/pprofreceiver/internal/self_scraper_test.go

@@ -7,13 +7,17 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
+	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/component/componenttest"
+
+	"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/pprofreceiver/internal/metadata"
 )
 
 func TestScrapeSelf(t *testing.T) {
 	s := SelfScraper{
 		BlockProfileFraction: 1,
 		MutexProfileFraction: 1,
+		BuildInfo:            component.BuildInfo{Version: "1.2.3"},
 	}
 	err := s.Start(t.Context(), componenttest.NewNopHost())
 	require.NoError(t, err)
@@ -23,4 +27,14 @@ func TestScrapeSelf(t *testing.T) {
 	p, err := s.ScrapeProfiles(t.Context())
 	require.NoError(t, err)
 	require.NotEqual(t, 0, p.ProfileCount())
+
+	sp := p.ResourceProfiles().At(0).ScopeProfiles().At(0)
+
+	require.Equal(
+		t,
+		metadata.ScopeName+"/selfscraper",
+		sp.Scope().Name(),
+	)
+
+	require.Equal(t, "1.2.3", sp.Scope().Version())
 }