Skip to content

Commit 259472c

Browse files
authored
[chore] Fix flaky Prometheus port collision in otelconftelemetry tests (#15731)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Uses new port for internal telemetry on each test to avoid flakiness because of port collision. <!--Authorship attestation. See AGENTS.md for details. AI agents must not check this box on behalf of the user; the human author must check it themselves before the PR is ready for review.--> #### Authorship - [x] I, a human, wrote this pull request description myself. <!--Please delete paragraphs that you did not use before submitting.-->
1 parent 8d9d794 commit 259472c

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

service/telemetry/otelconftelemetry/metrics_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,9 @@ func TestCreateMeterProvider_020MigrationWarning(t *testing.T) {
205205

206206
cfg := createDefaultConfig().(*Config)
207207
cfg.Metrics.MigratedFromV02 = true
208+
cfg.Metrics.Readers = []config.MetricReader{{
209+
Pull: &config.PullMetricReader{Exporter: config.PullMetricExporter{Prometheus: promtest.GetAvailableLocalAddressPrometheus(t)}},
210+
}}
208211

209212
resource, err := createResource(t.Context(), telemetry.Settings{}, cfg)
210213
require.NoError(t, err)
@@ -229,6 +232,9 @@ func TestCreateMeterProvider_NoMigrationWarning(t *testing.T) {
229232
core, observedLogs := observer.New(zapcore.DebugLevel)
230233

231234
cfg := createDefaultConfig().(*Config)
235+
cfg.Metrics.Readers = []config.MetricReader{{
236+
Pull: &config.PullMetricReader{Exporter: config.PullMetricExporter{Prometheus: promtest.GetAvailableLocalAddressPrometheus(t)}},
237+
}}
232238

233239
resource, err := createResource(t.Context(), telemetry.Settings{}, cfg)
234240
require.NoError(t, err)

0 commit comments

Comments
 (0)