[pdata/pprofile] Keep merge index construction out of the timed benchmark section

The per-entity switchDictionary benchmarks built the merge index inside
the timed section, so they measured index construction rather than the
merge, and were not comparable against the pre-index implementation.

Where the destination is rebuilt each iteration, the index is now built
alongside it under the existing StopTimer. Where the destination is built
once and accumulates across iterations (scope profiles, sample), the
index hoists out of the loop entirely, matching how MergeTo uses it.

Author: lazureykis

pdata/pprofile/function_test.go

@@ -339,9 +339,10 @@ func BenchmarkFunctionSwitchDictionary(b *testing.B) {
 		b.StopTimer()
 		dst := NewProfilesDictionary()
 		dst.StringTable().Append("", "foo")
+		mi := newMergeIndex(dst)
 		b.StartTimer()
 
-		_ = fn.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = fn.switchDictionary(src, dst, mi)
 	}
 }
 

pdata/pprofile/keyvalueandunit_test.go

@@ -260,9 +260,10 @@ func BenchmarkKeyValueAndUnitSwitchDictionary(b *testing.B) {
 	for b.Loop() {
 		b.StopTimer()
 		dst := NewProfilesDictionary()
+		mi := newMergeIndex(dst)
 		b.StartTimer()
 
-		_ = kvu.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = kvu.switchDictionary(src, dst, mi)
 	}
 }
 

pdata/pprofile/line_test.go

@@ -265,9 +265,10 @@ func BenchmarkLineSwitchDictionary(b *testing.B) {
 	for b.Loop() {
 		b.StopTimer()
 		dst := NewProfilesDictionary()
+		mi := newMergeIndex(dst)
 		b.StartTimer()
 
-		_ = l.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = l.switchDictionary(src, dst, mi)
 	}
 }
 

pdata/pprofile/location_test.go

@@ -343,9 +343,10 @@ func BenchmarkLocationSwitchDictionary(b *testing.B) {
 		dst.StringTable().Append("", "foo")
 		dst.AttributeTable().AppendEmpty()
 		dst.AttributeTable().AppendEmpty().SetKeyStrindex(1)
+		mi := newMergeIndex(dst)
 		b.StartTimer()
 
-		_ = l.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = l.switchDictionary(src, dst, mi)
 	}
 }
 

pdata/pprofile/mapping_test.go

@@ -292,9 +292,10 @@ func BenchmarkMappingSwitchDictionary(b *testing.B) {
 		dst.StringTable().Append("", "foo")
 		dst.AttributeTable().AppendEmpty()
 		dst.AttributeTable().AppendEmpty().SetKeyStrindex(1)
+		mi := newMergeIndex(dst)
 		b.StartTimer()
 
-		_ = m.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = m.switchDictionary(src, dst, mi)
 	}
 }
 

pdata/pprofile/profile_test.go

@@ -351,9 +351,10 @@ func BenchmarkProfileSwitchDictionary(b *testing.B) {
 		dst.StringTable().Append("", "foo")
 		dst.AttributeTable().AppendEmpty()
 		dst.AttributeTable().AppendEmpty().SetKeyStrindex(1)
+		mi := newMergeIndex(dst)
 		b.StartTimer()
 
-		_ = p.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = p.switchDictionary(src, dst, mi)
 	}
 }
 

pdata/pprofile/resourceprofiles_test.go

@@ -107,8 +107,9 @@ func BenchmarkResourceProfilesSwitchDictionary(b *testing.B) {
 	for b.Loop() {
 		b.StopTimer()
 		dst := NewProfilesDictionary()
+		mi := newMergeIndex(dst)
 		b.StartTimer()
 
-		_ = r.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = r.switchDictionary(src, dst, mi)
 	}
 }

pdata/pprofile/sample_test.go

@@ -330,9 +330,11 @@ func BenchmarkSampleSwitchDictionary(b *testing.B) {
 	src.LinkTable().AppendEmpty()
 	src.LinkTable().AppendEmpty().SetSpanID(pcommon.SpanID([8]byte{1, 2, 3, 4, 5, 6, 7, 8}))
 
+	mi := newMergeIndex(dst)
+
 	b.ReportAllocs()
 
 	for b.Loop() {
-		_ = s.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = s.switchDictionary(src, dst, mi)
 	}
 }

pdata/pprofile/scopeprofiles_test.go

@@ -103,10 +103,11 @@ func BenchmarkScopeProfilesSwitchDictionary(b *testing.B) {
 	src.LinkTable().AppendEmpty().SetSpanID(pcommon.SpanID([8]byte{1, 2, 3, 4, 5, 6, 7, 8}))
 
 	dst := NewProfilesDictionary()
+	mi := newMergeIndex(dst)
 
 	b.ReportAllocs()
 
 	for b.Loop() {
-		_ = s.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = s.switchDictionary(src, dst, mi)
 	}
 }

pdata/pprofile/stack_test.go

@@ -241,8 +241,9 @@ func BenchmarkStackSwitchDictionary(b *testing.B) {
 		dst := NewProfilesDictionary()
 		dst.LocationTable().AppendEmpty()
 		dst.LocationTable().AppendEmpty().SetAddress(43)
+		mi := newMergeIndex(dst)
 		b.StartTimer()
 
-		_ = s.switchDictionary(src, dst, newMergeIndex(dst))
+		_ = s.switchDictionary(src, dst, mi)
 	}
 }