Skip to content

Commit 9b1259c

Browse files
authored
Merge branch 'main' into pr-identity-fix
2 parents cbf3f83 + bf6bffc commit 9b1259c

29 files changed

Lines changed: 1208 additions & 10 deletions

.chloggen/config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ components:
9393
- pkg/xscraperhelper
9494
- processor/batch
9595
- processor/memory_limiter
96+
- processor/queuebatch
9697
- processor/sample
9798
- provider/env
9899
- provider/file
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: 'bug_fix'
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. receiver/otlp)
7+
component: cmd/mdatagen
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Removes the extra line in the documentation.md around description
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [15664]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: []

.chloggen/queuebatchprocessor.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: new_component
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. receiver/otlp)
7+
component: processor/queuebatch
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: "New `queuebatchprocessor` to replace the legacy `batchprocessor`."
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [15047, 13582, 12022, 11308, 8272, 6046]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext: "New implementation is based exporterhelper, uses same configuration as `sending_queue`."
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: [user]

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ processor/memorylimiterprocessor/ @open-telemetry/collector
9999
processor/processorhelper/ @open-telemetry/collector-approvers
100100
processor/processorhelper/xprocessorhelper/ @open-telemetry/collector-approvers
101101
processor/processortest/ @open-telemetry/collector-approvers
102+
processor/queuebatchprocessor/ @open-telemetry/collector-approvers @jmacd @iblancasa
102103
processor/xprocessor/ @open-telemetry/collector-approvers @mx-psi @dmathieu
103104
receiver/ @open-telemetry/collector-approvers
104105
receiver/nopreceiver/ @open-telemetry/collector-approvers @evan-bradley

.github/workflows/utils/cspell.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@
282282
"httpprovider",
283283
"httpsprovider",
284284
"httptest",
285+
"iblancasa",
285286
"icmpcheck",
286287
"icmpcheckreceiver",
287288
"illumos",

cmd/mdatagen/internal/loader_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ func TestLoadMetadata(t *testing.T) {
466466
"default.metric.to_be_removed": {
467467
Signal: Signal{
468468
Enabled: true,
469-
Description: "[DEPRECATED] Non-monotonic delta sum double metric enabled by default.",
469+
Description: "[DEPRECATED] Non-monotonic delta sum double metric enabled by default.\n",
470470
ExtendedDocumentation: "The metric will be removed soon.\n",
471471
Stability: component.StabilityLevelDeprecated,
472472
Warnings: Warnings{
@@ -514,7 +514,7 @@ func TestLoadMetadata(t *testing.T) {
514514
"default.event.to_be_renamed": {
515515
Signal: Signal{
516516
Enabled: false,
517-
Description: "[DEPRECATED] Example event disabled by default.",
517+
Description: "[DEPRECATED] Example event disabled by default.\n",
518518
ExtendedDocumentation: "The event will be renamed soon.\n",
519519
Warnings: Warnings{
520520
IfConfigured: "This event is deprecated and will be renamed soon.",

cmd/mdatagen/internal/samplereceiver/metadata.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,8 @@ events:
227227

228228
default.event.to_be_renamed:
229229
enabled: false
230-
description: "[DEPRECATED] Example event disabled by default."
230+
description: |
231+
[DEPRECATED] Example event disabled by default.
231232
extended_documentation: |
232233
The event will be renamed soon.
233234
attributes: [string_attr, boolean_attr, boolean_attr2, conditional_string_attr]
@@ -264,7 +265,8 @@ metrics:
264265

265266
default.metric.to_be_removed:
266267
enabled: true
267-
description: "[DEPRECATED] Non-monotonic delta sum double metric enabled by default."
268+
description: |
269+
[DEPRECATED] Non-monotonic delta sum double metric enabled by default.
268270
extended_documentation: |
269271
The metric will be removed soon.
270272
stability: deprecated

cmd/mdatagen/internal/templates/documentation.md.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
### {{ $metricName }}
66

7-
{{ $metric.Description }}
7+
{{ trimRight $metric.Description "\n" }}
88

99
{{- if $metric.ExtendedDocumentation }}
1010

@@ -64,7 +64,7 @@ When the disable-old gate is enabled, emission of this metric is suppressed. Whe
6464

6565
### {{ $eventName }}
6666

67-
{{ $event.Description }}
67+
{{ trimRight $event.Description "\n" }}
6868

6969
{{- if $event.ExtendedDocumentation }}
7070

cmd/mdatagen/internal/templates/metrics.go.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ type metric{{ $name.Render }} struct {
141141
// init fills {{ $name }} metric with initial data.
142142
func (m *metric{{ $name.Render }}) init() {
143143
m.data.SetName("{{ $name.EmittedName }}")
144-
m.data.SetDescription("{{ $metric.Description }}")
144+
m.data.SetDescription("{{ trimRight $metric.Description "\n" }}")
145145
m.data.SetUnit("{{ $metric.Unit }}")
146146
m.data.SetEmpty{{ $metric.Data.Type }}()
147147
{{- if $metric.Data.HasMonotonic }}

cmd/mdatagen/internal/templates/metrics_test.go.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ func TestMetricsBuilder(t *testing.T) {
321321
validatedMetrics["{{ $name }}"] = true
322322
assert.Equal(t, pmetric.MetricType{{ $metric.Data.Type }}, mi.Type())
323323
assert.Equal(t, 1, mi.{{ $metric.Data.Type }}().DataPoints().Len())
324-
assert.Equal(t, "{{ $metric.Description }}", mi.Description())
324+
assert.Equal(t, "{{ trimRight $metric.Description "\n" }}", mi.Description())
325325
{{- if len $metric.Unit}}
326326
assert.Equal(t, "{{ $metric.Unit }}", mi.Unit())
327327
{{- else }}
@@ -354,7 +354,7 @@ func TestMetricsBuilder(t *testing.T) {
354354
validatedMetrics["{{ $name }}"] = true
355355
assert.Equal(t, pmetric.MetricType{{ $metric.Data.Type }}, mi.Type())
356356
assert.Equal(t, 1, mi.{{ $metric.Data.Type }}().DataPoints().Len())
357-
assert.Equal(t, "{{ $metric.Description }}", mi.Description())
357+
assert.Equal(t, "{{ trimRight $metric.Description "\n" }}", mi.Description())
358358
{{- if len $metric.Unit}}
359359
assert.Equal(t, "{{ $metric.Unit }}", mi.Unit())
360360
{{- else }}
@@ -412,7 +412,7 @@ func TestMetricsBuilder(t *testing.T) {
412412
validatedMetrics["{{ $name }}"] = true
413413
assert.Equal(t, pmetric.MetricType{{ $metric.Data.Type }}, mi.Type())
414414
assert.Equal(t, 1, mi.{{ $metric.Data.Type }}().DataPoints().Len())
415-
assert.Equal(t, "{{ $metric.Description }}", mi.Description())
415+
assert.Equal(t, "{{ trimRight $metric.Description "\n" }}", mi.Description())
416416
{{- if len $metric.Unit}}
417417
assert.Equal(t, "{{ $metric.Unit }}", mi.Unit())
418418
{{- else }}

0 commit comments

Comments
 (0)