[service/telemetry] replace panic() with proper error handling (#15171)

#### Description

replace panic() with proper error handling

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Co-authored-by: Damien Mathieu <42@dmathieu.com>

Author: florianl

.chloggen/mustAttributeValueString-panic.yaml

@@ -0,0 +1,25 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: 'bug_fix'
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/otlp)
+component: pkg/service
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Non-string resource attributes in telemetry configuration now return an error instead of panicking
+
+# One or more tracking issues or pull requests related to the change
+issues: [15171]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

service/telemetry/otelconftelemetry/resource.go

@@ -25,7 +25,11 @@ func createResource(
 	pcommonRes := pcommon.NewResource()
 	for _, keyValue := range res.Attributes() {
 		key := string(keyValue.Key)
-		pcommonRes.Attributes().PutStr(key, mustAttributeValueString(key, keyValue.Value))
+		value, err := attributeValueString(key, keyValue.Value)
+		if err != nil {
+			return pcommon.Resource{}, err
+		}
+		pcommonRes.Attributes().PutStr(key, value)
 	}
 	return pcommonRes, nil
 }
@@ -34,12 +38,12 @@ func newResource(set telemetry.Settings, cfg *Config) *sdkresource.Resource {
 	return resource.New(set.BuildInfo, cfg.Resource)
 }
 
-func mustAttributeValueString(k string, v attribute.Value) string {
+func attributeValueString(k string, v attribute.Value) (string, error) {
 	if v.Type() != attribute.STRING {
 		// We only support string-type resource attributes in the configuration.
-		panic(fmt.Errorf("attribute %q: expected string, got %s", k, v.Type()))
+		return "", fmt.Errorf("attribute %q: expected string, got %s", k, v.Type())
 	}
-	return v.AsString()
+	return v.AsString(), nil
 }
 
 // pcommonAttrsToOTelAttrs gets the Resource attributes to OpenTelemetry attribute.KeyValue slice.

service/telemetry/otelconftelemetry/resource_test.go

@@ -8,6 +8,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"go.opentelemetry.io/otel/attribute"
 
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/service/telemetry"
@@ -48,3 +49,36 @@ func TestCreateResource(t *testing.T) {
 		}, raw)
 	})
 }
+
+func TestAttributeValueString(t *testing.T) {
+	t.Run("string attribute", func(t *testing.T) {
+		val := attribute.StringValue("test-value")
+		result, err := attributeValueString("test.attr", val)
+		require.NoError(t, err)
+		assert.Equal(t, "test-value", result)
+	})
+
+	t.Run("int64 attribute returns error", func(t *testing.T) {
+		val := attribute.Int64Value(42)
+		result, err := attributeValueString("test.attr", val)
+		require.Error(t, err)
+		assert.Empty(t, result)
+		assert.Contains(t, err.Error(), `attribute "test.attr": expected string, got INT64`)
+	})
+
+	t.Run("bool attribute returns error", func(t *testing.T) {
+		val := attribute.BoolValue(true)
+		result, err := attributeValueString("test.attr", val)
+		require.Error(t, err)
+		assert.Empty(t, result)
+		assert.Contains(t, err.Error(), `attribute "test.attr": expected string, got BOOL`)
+	})
+
+	t.Run("float64 attribute returns error", func(t *testing.T) {
+		val := attribute.Float64Value(3.14)
+		result, err := attributeValueString("test.attr", val)
+		require.Error(t, err)
+		assert.Empty(t, result)
+		assert.Contains(t, err.Error(), `attribute "test.attr": expected string, got FLOAT64`)
+	})
+}

service/telemetry/otelconftelemetry/sdk.go

@@ -15,9 +15,13 @@ func newSDK(ctx context.Context, res *sdkresource.Resource, conf config.OpenTele
 	resourceAttrs := make([]config.AttributeNameValue, 0, res.Len())
 	for _, r := range res.Attributes() {
 		key := string(r.Key)
+		value, err := attributeValueString(key, r.Value)
+		if err != nil {
+			return config.SDK{}, err
+		}
 		resourceAttrs = append(resourceAttrs, config.AttributeNameValue{
 			Name:  key,
-			Value: mustAttributeValueString(key, r.Value),
+			Value: value,
 		})
 	}
 	conf.Resource = &config.Resource{