Address review comment from copilot-pull-request-reviewer: restrict counter advice

Author: trask

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingMetricsAdvice.java

@@ -61,20 +61,22 @@ final class MessagingMetricsAdvice {
           SERVER_ADDRESS);
 
   private static final List<AttributeKey<?>> CLIENT_OPERATION_DURATION_ATTRIBUTES =
-      buildAttributes(true, true);
+      buildAttributes(true, true, true);
   private static final List<AttributeKey<?>> SENT_MESSAGES_ATTRIBUTES =
-      buildAttributes(false, false);
+      buildAttributes(false, false, false);
   private static final List<AttributeKey<?>> CONSUMED_MESSAGES_ATTRIBUTES =
-      buildAttributes(true, false);
+      buildAttributes(true, false, false);
   private static final List<AttributeKey<?>> PROCESS_DURATION_ATTRIBUTES =
-      buildAttributes(true, false);
+      buildAttributes(true, false, true);
 
   private static List<AttributeKey<?>> buildAttributes(
-      boolean includeConsumerAttributes, boolean includeOperationType) {
+      boolean includeConsumerAttributes, boolean includeOperationType, boolean includeErrorType) {
     List<AttributeKey<?>> attributes = new ArrayList<>();
     attributes.add(MESSAGING_OPERATION_NAME);
     attributes.add(MESSAGING_SYSTEM);
-    attributes.add(ERROR_TYPE);
+    if (includeErrorType) {
+      attributes.add(ERROR_TYPE);
+    }
     if (includeConsumerAttributes) {
       attributes.add(MESSAGING_CONSUMER_GROUP_NAME);
     }

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingConsumerMetricsTest.java

@@ -165,10 +165,7 @@ void collectsMetricsAndCountsBatchOnce() {
                                               equalTo(MESSAGING_DESTINATION_TEMPLATE, "topic-{id}"),
                                               equalTo(
                                                   MESSAGING_DESTINATION_SUBSCRIPTION_NAME,
-                                                  "subscription"),
-                                              equalTo(
-                                                  ERROR_TYPE,
-                                                  IllegalStateException.class.getName())))));
+                                                  "subscription")))));
     }
   }
 

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingProducerMetricsTest.java

@@ -145,9 +145,6 @@ void collectsMetrics() {
                                               equalTo(MESSAGING_OPERATION_NAME, "send"),
                                               equalTo(MESSAGING_SYSTEM, "pulsar"),
                                               equalTo(MESSAGING_DESTINATION_TEMPLATE, "topic-{id}"),
-                                              equalTo(
-                                                  ERROR_TYPE,
-                                                  IllegalStateException.class.getName()),
                                               equalTo(SERVER_ADDRESS, "localhost"),
                                               equalTo(MESSAGING_DESTINATION_PARTITION_ID, "1"),
                                               equalTo(SERVER_PORT, 6650)))));