Review fixes for jsf-myfaces-3.0:javaagent (#18128)

Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>

Author: otelbot[bot]

instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/v3_0/ActionListenerImplInstrumentation.java

@@ -58,7 +58,7 @@ public static AdviceScope start(ActionEvent event) {
         return new AdviceScope(request, context, scope);
       }
 
-      public void end(Throwable throwable) {
+      public void end(@Nullable Throwable throwable) {
         scope.close();
         instrumenter().end(context, request, null, throwable);
       }

instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/v3_0/MyFacesErrorCauseExtractor.java

@@ -8,7 +8,7 @@
 import io.opentelemetry.javaagent.instrumentation.jsf.jakarta.JsfErrorCauseExtractor;
 import jakarta.el.ELException;
 
-public class MyFacesErrorCauseExtractor extends JsfErrorCauseExtractor {
+class MyFacesErrorCauseExtractor extends JsfErrorCauseExtractor {
 
   @Override
   public Throwable extract(Throwable error) {

instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/v3_0/MyFacesSingletons.java

@@ -10,7 +10,7 @@
 import io.opentelemetry.javaagent.bootstrap.internal.ExperimentalConfig;
 import io.opentelemetry.javaagent.instrumentation.jsf.jakarta.JsfRequest;
 
-public class MyFacesSingletons {
+class MyFacesSingletons {
   private static final String INSTRUMENTATION_NAME = "io.opentelemetry.jsf-myfaces-3.0";
 
   private static final Instrumenter<JsfRequest, Void> instrumenter;
@@ -24,7 +24,7 @@ public class MyFacesSingletons {
             .buildInstrumenter();
   }
 
-  public static Instrumenter<JsfRequest, Void> instrumenter() {
+  static Instrumenter<JsfRequest, Void> instrumenter() {
     return instrumenter;
   }
 

instrumentation/jsf/jsf-myfaces-3.0/metadata.yaml

@@ -7,6 +7,7 @@ features:
 library_link: https://myfaces.apache.org/
 configurations:
   - name: otel.instrumentation.common.experimental.controller-telemetry.enabled
+    declarative_name: java.common.controller_telemetry/development.enabled
     description: Enables the creation of experimental controller spans.
     type: boolean
     default: false