Address review comments from copilot-pull-request-reviewer: require messaging operation name

Author: trask

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractorBuilder.java

@@ -19,8 +19,8 @@
 public final class MessagingAttributesExtractorBuilder<REQUEST, RESPONSE> {
 
   final MessagingAttributesGetter<REQUEST, RESPONSE> getter;
-  @Nullable MessagingOperationType operationType;
-  @Nullable String operationName;
+  @Nullable private final MessagingOperationType operationType;
+  @Nullable private String operationName;
   private final boolean supportsStableSemconv;
   List<String> capturedHeaders = emptyList();
 
@@ -63,6 +63,9 @@ public MessagingAttributesExtractorBuilder<REQUEST, RESPONSE> setCapturedHeaders
    * MessagingAttributesExtractorBuilder}.
    */
   public AttributesExtractor<REQUEST, RESPONSE> build() {
+    if (supportsStableSemconv) {
+      requireNonNull(operationName, "operationName");
+    }
     return new MessagingAttributesExtractor<>(
         getter, operationType, operationName, supportsStableSemconv, capturedHeaders);
   }

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractorTest.java

@@ -25,6 +25,7 @@
 import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_SYSTEM;
 import static java.util.Collections.emptyMap;
 import static java.util.Collections.singletonMap;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.assertj.core.api.Assertions.entry;
 import static org.junit.jupiter.params.provider.Arguments.argumentSet;
 
@@ -227,11 +228,21 @@ void shouldExtractOperationNameWithoutOperationType() {
     assertThat(attributes.build()).isEqualTo(expected);
   }
 
+  @Test
+  void shouldRequireOperationNameForStableSemconv() {
+    assertThatThrownBy(
+            () ->
+                MessagingAttributesExtractor.builderForOperationType(TestGetter.INSTANCE, null)
+                    .build())
+        .isInstanceOf(NullPointerException.class)
+        .hasMessage("operationName");
+  }
+
   @Test
   void shouldExtractErrorTypeFromResponse() {
-    MessagingOperationType operationType = null;
     AttributesExtractor<Map<String, String>, String> underTest =
-        MessagingAttributesExtractor.createForOperationType(TestGetter.INSTANCE, operationType);
+        MessagingAttributesExtractor.createForOperationType(
+            TestGetter.INSTANCE, MessagingOperationType.RECEIVE);
 
     AttributesBuilder attributes = Attributes.builder();
     underTest.onEnd(attributes, Context.root(), emptyMap(), "failure", null);