Gate Dubbo registry server.address/server.port behind stable rpc semconv#19285
Merged
trask merged 2 commits intoJul 21, 2026
Merged
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-21 13:24:22 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, report it with the result you expected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Gates registry-derived Dubbo server.* attributes behind stable RPC semantic conventions, preserving legacy provider addresses by default.
Changes:
- Applies semantic-convention gating to client server address and port extraction.
- Updates registry integration assertions for stable and legacy modes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
AbstractDubboRegistryTest.java |
Tests mode-specific registry attributes. |
DubboClientNetworkAttributesGetter.java |
Gates registry target emission. |
trask
marked this pull request as ready for review
July 21, 2026 05:10
…x client peer.service under old semconv
steverao
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17244, which changed registry-backed Dubbo client
server.address/server.portunconditionally. That altered already-emitted attributes for all users by default: registry-backed consumers previously reported the resolved provider host/port, and #17244 switchedserver.addressto the registry endpoint plus service target (registry://host:port/interface:version:group) withserver.portunset.This gates that behavior behind
emitStableRpcSemconv()(otel.semconv-stability.opt-in=rpc), matching the gRPC target approach in #16161. Under the old semconv the resolved provider host/port are kept; the registry-address form is only emitted under the stable rpc opt-in. The registry capture itself is unchanged — only the emittedserver.*attributes are gated.Prototype for open-telemetry/semantic-conventions#3317.