Fix duplicate Maven publication coordinates#19294
Merged
trask merged 2 commits intoJul 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes conflicting Maven coordinates that caused the 2.30.0 deployment failure.
Changes:
- Adds the expected SOFARPC autoconfigure artifact suffix.
- Detects duplicate Maven publication coordinates.
- Runs validation during checks and repository publication.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
instrumentation/sofa-rpc-5.4/library-autoconfigure/build.gradle.kts |
Assigns unique autoconfigure coordinates. |
conventions/src/main/kotlin/io/opentelemetry/instrumentation/gradle/CheckMavenPublicationCoordinatesTask.kt |
Implements duplicate-coordinate validation. |
build.gradle.kts |
Collects coordinates and wires validation into checks and publishing. |
Pull request dashboard statusStatus last refreshed: 2026-07-22 18:28:03 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
jaydeluca
approved these changes
Jul 22, 2026
breedx-splk
reviewed
Jul 22, 2026
| @TaskAction | ||
| fun checkPublicationCoordinates() { | ||
| val duplicatePublications = publicationCoordinates.get() | ||
| .groupBy { it.substringBefore('=') } |
Contributor
There was a problem hiding this comment.
stringBefore!!! I love that.
breedx-splk
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.30.0 Maven Central deployment failed because the Sofa RPC library and library-autoconfigure projects published different artifacts using the same Maven coordinates. Parallel publication into the shared release repository produced mismatched JARs, checksums, and signatures.
This change:
-autoconfiguresuffixchecktasks and before everyPublishToMavenRepositorytask