With the update to simplecov we are now getting the followingin our logs:
[DEPRECATION] Calling SimpleCov.start from .simplecov is deprecated and will be removed in a future release. .simplecov should contain configuration only; move the SimpleCov.start call into your spec_helper.rb / test_helper.rb. Coverage tracking still begins for backward compatibility, but a future release will require the explicit SimpleCov.start from a test helper. See simplecov-ruby/simplecov#581.
As such we should switch to calling it from our test helper.
While as it we should review how we are setting the command name as i suspect we don't need the overrides. Key thing to be checked is that each appraisal generates a differently named coverage report.
Also the coverage target percentage can likely come out of ci and purely env variables.
With the update to simplecov we are now getting the followingin our logs:
As such we should switch to calling it from our test helper.
While as it we should review how we are setting the command name as i suspect we don't need the overrides. Key thing to be checked is that each appraisal generates a differently named coverage report.
Also the coverage target percentage can likely come out of ci and purely env variables.