Release 0.13.0

multipath-tools 0.13.0

Author: mwilck

.clang-format

@@ -0,0 +1,32 @@
+# -*- yaml -*-
+---
+BasedOnStyle: LLVM
+IndentWidth: 8
+ContinuationIndentWidth: 8
+UseTab: Always
+TabWidth: 8
+BreakBeforeBraces: Linux
+BreakStringLiterals: false
+AllowShortFunctionsOnASingleLine: Empty
+AlignAfterOpenBracket: Align
+PointerAlignment: Right
+ColumnLimit: 79
+PenaltyBreakAssignment: 50
+PenaltyBreakBeforeFirstCallParameter: 200
+#PenaltyBreakBeforeMemberAccess: 250
+PenaltyBreakComment: 50
+PenaltyBreakOpenParenthesis: 200
+PenaltyBreakString: 300
+PenaltyExcessCharacter: 5
+PenaltyIndentedWhitespace: 2
+PenaltyReturnTypeOnItsOwnLine: 50
+SortIncludes: Never
+AlignConsecutiveMacros: AcrossEmptyLinesAndComments
+AlignConsecutiveAssignments: None
+AlignConsecutiveDeclarations: None
+SkipMacroDefinitionBody: true
+ForEachMacros:
+  - vector_foreach_slot
+  - vector_foreach_slot_backwards
+  - vector_foreach_slot_after
+---

.clang-format-ignore

@@ -0,0 +1,3 @@
+Makefile*
+libmultipath/hwtable.c
+multipathd/cli.h

.github/actions/spelling/expect.txt

@@ -55,8 +55,10 @@ dmraid
 dmsetup
 dracut
 EAGAIN
+ECKD
 emc
 Engenio
+Equal
 EVPD
 failback
 failover
@@ -92,6 +94,7 @@ ifndef
 igroup
 img
 Infini
+Infinidat
 inotify
 inttypes
 ioctls
@@ -142,6 +145,7 @@ NOLOG
 nompath
 NOSCAN
 Nosync
+NVMe
 nvme
 NFINIDAT
 OBJDEPS
@@ -167,6 +171,7 @@ prioritizer
 prkeys
 PROUT
 pthreads
+QSAN
 rdac
 rdma
 readcap
@@ -180,7 +185,7 @@ reconfig
 redhat
 restorequeueing
 retrigger
-RETRYABLE
+retryable
 rhabarber
 rootprefix
 rootprefixdir
@@ -193,7 +198,6 @@ sbp
 scsi
 SCST
 sda
-sdc
 Seagate
 setmarginal
 setprkey
@@ -217,7 +221,6 @@ switchgroup
 sys
 sysfs
 sysinit
-systemd
 tcp
 terabytes
 SYSDIR
@@ -237,6 +240,7 @@ udevd
 uevent
 uid
 unitdir
+unregistering
 unsetmarginal
 unsetprkey
 unsetprstatus
@@ -255,7 +259,6 @@ VNX
 vpd
 VSN
 wakka
-watchdogsec
 weightedpath
 wholedisk
 Wilck

.github/workflows/codingstyle.yml

@@ -0,0 +1,43 @@
+name: Check coding style
+
+on:
+  push:
+    branches:
+      - master
+      - queue
+      - tip
+      - 'stable-*'
+    paths:
+      - '.clang-format'
+      - '.github/workflows/codingstyle.yaml'
+      - '**.h'
+      - '**.c'
+  pull_request:
+    branches:
+      - master
+      - queue
+      - 'stable-*'
+    paths:
+      - '.clang-format'
+      - '.github/workflows/codingstyle.yaml'
+      - '**.h'
+      - '**.c'
+
+permissions:
+  contents: read
+
+jobs:
+  stylecheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - run: >-
+          echo "BASEREF=${{ github.event.pull_request.base.sha }}" >>$GITHUB_ENV
+        if: ${{ github.event_name == 'pull_request' }}
+      - run: >-
+          echo "BASEREF=${{ github.event.before }}" >>$GITHUB_ENV
+        if: ${{ github.event_name == 'push' }}
+      - run: git fetch --depth=1 origin ${{ env.BASEREF }}
+      - uses: yshui/git-clang-format-lint@master
+        with:
+          base: ${{ env.BASEREF }}

NEWS.md

@@ -9,6 +9,52 @@ release. These bug fixes will be tracked in stable branches.
 
 See [README.md](README.md) for additional information.
 
+## multipath-tools 0.13.0, 2025/10
+
+### Major rework of the SCSI Persistent Reservation code
+
+The mpathpersist code had many areas where it did a poor job of
+mimicking the behavior of setting up persistent reservations on an
+individual device, especially if some paths to the multipath device
+were missing or unusable.
+
+Issues improved in this release:
+
+* Persistent reservation operations in cases where the reservation
+  is held held by an unavailable path. For example, when such a key
+  is unregistered, libmpathpersist now preempts the old key
+  after verifying that the multipath device is holding the reservation.
+* Releasing a reservation held by an unavailable path. This has always
+  had code to handle it, but it relied on optional Persistent
+  Reservation features. The new code preempts the key and then restores
+  the removed registered keys while the device is suspended.
+* Handling removal of keys from paths that were down when the multipath
+  device was unregistered.
+* Changing how conflicts on key registration are handled. Instead of
+  the old rollback method (which was broken anyway),
+  libmpathpersist now retries with REGISTER AND IGNORE as long as the
+  REGISTER command completed successfully down some of the paths.
+* Changing when the reservation key is set to fix corner cases on
+  failure and registration while paths are coming up.
+* Retrying to fix corner cases when a path is coming up while doing a
+  reserve, preempt or clear.
+* Allowing registrations to succeed when there are retryable errors,
+  if the paths are actually down.
+* Fixing the reservation key validation in some commands.
+* Handling a race condition that may occur while changing the reservation key
+  of a multipath map.
+* Handling preemption of registrations of type "all registrants".
+
+In the course of making these changes, a number of corner cases were fixed,
+too. Please consult the commit messages for details.
+
+### Other changes
+
+* Updates to the built-in hardware table:
+  - add some NVMe storage array (VASTData, Infinidat, HITACHI VSP)
+  - add QSAN
+  - add EqualLogic PS
+
 ## multipath-tools 0.12.0, 2025/08
 
 ### User-visible changes

libmpathpersist/libmpathpersist.version

@@ -34,11 +34,10 @@ global:
 	mpath_persistent_reserve_out__;
 } LIBMPATHPERSIST_2.1.0;
 
-__LIBMPATHPERSIST_INT_1.1.0 {
+__LIBMPATHPERSIST_INT_2.1.0 {
 	/* Internal use by multipath-tools */
 	dumpHex;
 	mpath_alloc_prin_response;
 	prin_do_scsi_ioctl;
 	prout_do_scsi_ioctl;
-	update_map_pr;
 };

libmpathpersist/mpath_persist.h

@@ -65,6 +65,9 @@ extern "C" {
 #define MPATH_PR_RETRYABLE_ERROR	16  /* error that might be succeed
 					       down another path. Internal
 					       only. */
+#define MPATH_PR_SUCCESS_UNREGISTER	17  /* Success, and additionally, all
+					       paths were unregistered.
+					       Internal only. */
 
 /* PR MASK */
 #define MPATH_F_APTPL_MASK		0x01	/* APTPL MASK*/