Merge branch 'workflows' into stable-0.12.y

Signed-off-by: Martin Wilck <mwilck@suse.com>

Author: mwilck

.github/workflows/abi-stable.yaml

@@ -21,32 +21,48 @@ jobs:
         run: >
           echo ${{ github.ref }} |
           sed -E 's,refs/heads/stable-([0-9]\.[0-9]*)\.y,PARENT_TAG=\1.0,' >> $GITHUB_ENV
-        if: ${{ github.event_name == 'push' }}
+        if: github.event_name == 'push'
       - name: get parent tag (PR)
         run: >
           echo ${{ github.base_ref }} |
           sed -E 's,stable-([0-9]\.[0-9]*)\.y,PARENT_TAG=\1.0,' >> $GITHUB_ENV
-        if: ${{ github.event_name == 'pull_request' }}
+        if: github.event_name == 'pull_request'
       - name: assert parent tag
         run: /bin/false
-        if: ${{ env.PARENT_TAG == '' }}
+        if: env.PARENT_TAG == ''
+      - name: try to download ABI for ${{ env.PARENT_TAG }}
+        id: download_abi
+        continue-on-error: true
+        uses: dawidd6/action-download-artifact@v21
+        with:
+          workflow: abi-stable.yaml
+          workflow_conclusion: ''
+          branch: ${{ github.ref_name }}
+          name: multipath-abi-${{ env.PARENT_TAG }}
+          search_artifacts: true
+          path: __unused__
       - name: update
+        if: steps.download_abi.outcome != 'success'
         run: sudo apt-get update
       - name: dependencies
+        if: steps.download_abi.outcome != 'success'
         run: >
           sudo apt-get install --yes gcc
           gcc make pkg-config abigail-tools
           libdevmapper-dev libreadline-dev libaio-dev libsystemd-dev
           libudev-dev libjson-c-dev liburcu-dev libcmocka-dev libedit-dev
           libmount-dev
       - name: checkout ${{ env.PARENT_TAG }}
-        uses: actions/checkout@v4
+        if: steps.download_abi.outcome != 'success'
+        uses: actions/checkout@v7
         with:
           ref: ${{ env.PARENT_TAG }}
       - name: build ABI for ${{ env.PARENT_TAG }}
+        if: steps.download_abi.outcome != 'success'
         run: make -j$(nproc) -Orecurse abi
       - name: save ABI
-        uses: actions/upload-artifact@v4
+        if: steps.download_abi.outcome != 'success'
+        uses: actions/upload-artifact@v7
         with:
           name: multipath-abi-${{ env.PARENT_TAG }}
           path: abi
@@ -59,28 +75,31 @@ jobs:
         run: >
           echo ${{ github.ref }} |
           sed -E 's,refs/heads/stable-([0-9]\.[0-9]*)\.y,PARENT_TAG=\1.0,' >> $GITHUB_ENV
-        if: ${{ github.event_name == 'push' }}
+        if: github.event_name == 'push'
       - name: get parent tag (PR)
         run: >
           echo ${{ github.base_ref }} |
           sed -E 's,stable-([0-9]\.[0-9]*)\.y,PARENT_TAG=\1.0,' >> $GITHUB_ENV
-        if: ${{ github.event_name == 'pull_request' }}
+        if: github.event_name == 'pull_request'
       - name: assert parent tag
         run: /bin/false
-        if: ${{ env.PARENT_TAG == '' }}
+        if: env.PARENT_TAG == ''
       - name: checkout ${{ github.ref }}
-        uses: actions/checkout@v4
+        uses: actions/checkout@v7
         with:
           ref: ${{ github.ref }}
       - name: download ABI for ${{ env.PARENT_TAG }}
         id: download_abi
-        uses: actions/download-artifact@v4
+        uses: dawidd6/action-download-artifact@v21
         with:
+          workflow: abi-stable.yaml
+          workflow_conclusion: ''
+          branch: ${{ github.ref_name }}
           name: multipath-abi-${{ env.PARENT_TAG }}
+          search_artifacts: true
           path: reference-abi
       - name: update
         run: sudo apt-get update
-        if: steps.download_abi.outcome != 'success'
       - name: dependencies
         run: >
           sudo apt-get install --yes gcc
@@ -93,8 +112,8 @@ jobs:
         run: make -j$(nproc) -Orecurse abi-test
         continue-on-error: true
       - name: save differences
-        if: ${{ steps.check_abi.outcome != 'success' }}
-        uses: actions/upload-artifact@v4
+        if: steps.check_abi.outcome != 'success'
+        uses: actions/upload-artifact@v7
         with:
           name: abi-test
           path: abi-test

.github/workflows/abi.yaml

@@ -2,6 +2,7 @@ name: check-abi
 on:
   push:
     branches:
+      - master
       - queue
       - abi
     paths:
@@ -21,14 +22,14 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - name: set ABI branch
-        if: ${{ env.ABI_BRANCH == '' }}
+        if: env.ABI_BRANCH == ''
         run: echo "ABI_BRANCH=master" >> $GITHUB_ENV
       - name: checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v7
       - name: get reference ABI
         id: reference
         continue-on-error: true
-        uses: dawidd6/action-download-artifact@v6
+        uses: dawidd6/action-download-artifact@v21
         with:
           workflow: abi.yaml
           branch: ${{ env.ABI_BRANCH }}
@@ -46,19 +47,19 @@ jobs:
       - name: create ABI
         run: make -Orecurse -j$(nproc) abi.tar.gz
       - name: save ABI
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: abi
           path: abi
           overwrite: true
       - name: compare ABI against reference
         id: compare
         continue-on-error: true
-        if: ${{ steps.reference.outcome == 'success' }}
+        if: steps.reference.outcome == 'success'
         run: make abi-test
       - name: save differences
-        if: ${{ steps.compare.outcome == 'failure' }}
-        uses: actions/upload-artifact@v4
+        if: steps.compare.outcome == 'failure'
+        uses: actions/upload-artifact@v7
         with:
           name: abi-test
           path: abi-test

.github/workflows/build-and-unittest.yaml

@@ -20,7 +20,7 @@ jobs:
         rl: ['', 'libreadline', 'libedit']
         cc: [ gcc, clang ]
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v7
       - name: update
         run: sudo apt-get update
       - name: dependencies
@@ -43,7 +43,7 @@ jobs:
       - name: set optflags
         # valgrind doesn't support the dwarf-5 format of clang 14
         run: echo OPT='-O2 -gdwarf-4 -fstack-protector-strong' >> $GITHUB_ENV
-        if: ${{ matrix.cc == 'clang' }}
+        if: matrix.cc == 'clang'
       - name: build
         run: >
           make -Orecurse -j$(nproc)
@@ -67,6 +67,8 @@ jobs:
         run: rm -f tests/dmevents.out tests/directio.out
       - name: root-test
         run: sudo make DIO_TEST_DEV=/dev/zram$ZRAM test
+      - name: kpartx-test
+        run: sudo make -C kpartx test
   noble:
     runs-on: ubuntu-24.04
     strategy:
@@ -75,7 +77,7 @@ jobs:
         rl: ['', 'libreadline', 'libedit']
         cc: [ gcc, clang ]
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v7
       - name: mpath
         run: sudo modprobe dm_multipath
       - name: brd
@@ -108,3 +110,5 @@ jobs:
         run: rm -f tests/dmevents.out tests/directio.out
       - name: root-test
         run: sudo make DIO_TEST_DEV=/dev/ram0 test
+      - name: kpartx-test
+        run: sudo make -C kpartx test

.github/workflows/codingstyle.yml

@@ -0,0 +1,43 @@
+name: Check coding style
+
+on:
+  push:
+    branches:
+      - master
+      - queue
+      - tip
+      - 'stable-*'
+    paths:
+      - '.clang-format'
+      - '.github/workflows/codingstyle.yaml'
+      - '**.h'
+      - '**.c'
+  pull_request:
+    branches:
+      - master
+      - queue
+      - 'stable-*'
+    paths:
+      - '.clang-format'
+      - '.github/workflows/codingstyle.yaml'
+      - '**.h'
+      - '**.c'
+
+permissions:
+  contents: read
+
+jobs:
+  stylecheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - run: >-
+          echo "BASEREF=${{ github.event.pull_request.base.sha }}" >>$GITHUB_ENV
+        if: github.event_name == 'pull_request'
+      - run: >-
+          echo "BASEREF=${{ github.event.before }}" >>$GITHUB_ENV
+        if: github.event_name == 'push'
+      - run: git fetch --depth=1 origin ${{ env.BASEREF }}
+      - uses: yshui/git-clang-format-lint@master
+        with:
+          base: ${{ env.BASEREF }}

.github/workflows/coverity.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - name: checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v7
       - name: dependencies
         run: >
           sudo apt-get install --yes

.github/workflows/foreign.yaml

@@ -41,11 +41,11 @@ jobs:
     container: ghcr.io/mwilck/multipath-cross-debian_cross-${{ matrix.os }}-${{ matrix.arch }}
     steps:
       - name: checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v7
       - name: build
         run: make -j$(nproc) -Orecurse test-progs.tar
       - name: upload binary archive
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: cross-${{ matrix.os }}-${{ matrix.arch }}
           path: test-progs.tar
@@ -67,31 +67,51 @@ jobs:
     steps:
       - name: set container arch
         run: echo CONTAINER_ARCH="${{ matrix.arch }}" >> $GITHUB_ENV
-        if: ${{ matrix.arch != 'armhf' }}
+        if: matrix.arch != 'armhf'
       - name: set container arch
         run: echo CONTAINER_ARCH="arm/v7" >> $GITHUB_ENV
-        if: ${{ matrix.arch == 'armhf' }}
+        if: matrix.arch == 'armhf'
       - name: download binary archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: cross-${{ matrix.os }}-${{ matrix.arch }}
       - name: unpack binary archive
         run: tar xfv test-progs.tar
       - name: enable foreign arch
-        uses: docker/setup-qemu-action@v2
+        uses: docker/setup-qemu-action@v4
         with:
           image: tonistiigi/binfmt:latest
+      - name: Set coredump pattern
+        run: |
+          echo 'core.%e.%p' | sudo tee /proc/sys/kernel/core_pattern
       - name: run tests
-        uses: mosteo-actions/docker-run@v1
+        id: test
+        run: |
+          docker run \
+            --pids-limit 4096 \
+            --workdir /__w/multipath-tools/multipath-tools \
+            --platform linux/${{ env.CONTAINER_ARCH }} \
+            -w /__w/multipath-tools/multipath-tools \
+            -v${{ github.workspace }}:/__w/multipath-tools/multipath-tools \
+            ghcr.io/mwilck/multipath-run-debian-${{ matrix.os }} -C tests
+        continue-on-error: true
+      - name: Make core dumps accessible
+        run: |
+          find . \( -name 'core*' \) -print0 | xargs -0 -r sudo chmod a+x
+        if: steps.test.outcome != 'success'
+      - name: save test outputs
+        run: make test-outputs.tar
+        if: steps.test.outcome != 'success'
+      - name: upload test outputs
+        uses: actions/upload-artifact@v7
         with:
-          image: ghcr.io/mwilck/multipath-run-debian-${{ matrix.os }}
-          guest-dir: /__w/multipath-tools/multipath-tools
-          host-dir: ${{ github.workspace }}
-          command: -C tests
-          params: >
-            --workdir /__w/multipath-tools/multipath-tools
-            --platform linux/${{ env.CONTAINER_ARCH }}
-          pull-params: "--platform linux/${{ env.CONTAINER_ARCH }}"
+          name: test-${{ matrix.os }}-${{ matrix.arch }}
+          path: test-outputs.tar
+          overwrite: true
+        if: steps.test.outcome != 'success'
+      - name: fail if test failed
+        run: /bin/false
+        if: steps.test.outcome != 'success'
 
   root-test:
     runs-on: ubuntu-24.04
@@ -113,37 +133,51 @@ jobs:
         run: sudo modprobe brd rd_nr=1 rd_size=65536
       - name: set container arch
         run: echo CONTAINER_ARCH="${{ matrix.arch }}" >> $GITHUB_ENV
-        if: ${{ matrix.arch != 'armhf' }}
+        if: matrix.arch != 'armhf'
       - name: set container arch
         run: echo CONTAINER_ARCH="arm/v7" >> $GITHUB_ENV
-        if: ${{ matrix.arch == 'armhf' }}
+        if: matrix.arch == 'armhf'
       - name: download binary archive
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: cross-${{ matrix.os }}-${{ matrix.arch }}
       - name: unpack binary archive
         run: tar xfv test-progs.tar
       - name: enable foreign arch
-        uses: docker/setup-qemu-action@v2
+        uses: docker/setup-qemu-action@v4
         with:
           image: tonistiigi/binfmt:latest
+      - name: Set coredump pattern
+        run: |
+          echo 'core.%e.%p' | sudo tee /proc/sys/kernel/core_pattern
       - name: run tests
-        uses: mosteo-actions/docker-run@v1
-        with:
-          image: ghcr.io/mwilck/multipath-run-debian-${{ matrix.os }}
-          guest-dir: /__w/multipath-tools/multipath-tools
-          host-dir: ${{ github.workspace }}
-          command: -C tests dmevents.out
-          params: >
-            --workdir /__w/multipath-tools/multipath-tools
-            --platform linux/${{ env.CONTAINER_ARCH }}
-            --privileged
-            -v /dev/ram0:/dev/ram0 -e DIO_TEST_DEV=/dev/ram0
-          pull-params: "--platform linux/${{ env.CONTAINER_ARCH }}"
         id: root-test
+        run: |
+          docker run \
+            --workdir /__w/multipath-tools/multipath-tools \
+            --pids-limit 4096 \
+            --platform linux/${{ env.CONTAINER_ARCH }} \
+            --privileged \
+            -v /dev/ram0:/dev/ram0 -e DIO_TEST_DEV=/dev/ram0 \
+            -w /__w/multipath-tools/multipath-tools \
+            -v${{ github.workspace }}:/__w/multipath-tools/multipath-tools \
+            ghcr.io/mwilck/multipath-run-debian-${{ matrix.os }} \
+            -C tests dmevents.out
         continue-on-error: true
-      - name: show root test output
-        run: for o in tests/*.out; do echo "===== $o ====="; cat "$o"; done
-      - name: fail
+      - name: Make core dumps accessible
+        run: |
+          find . \( -name 'core*' \) -print0 | xargs -0 -r sudo chmod a+x
+        if: steps.root-test.outcome != 'success'
+      - name: save test outputs
+        run: make test-outputs.tar
+        if: steps.root-test.outcome != 'success'
+      - name: upload test outputs
+        uses: actions/upload-artifact@v7
+        with:
+          name: root-test-${{ matrix.os }}-${{ matrix.arch }}
+          path: test-outputs.tar
+          overwrite: true
+        if: steps.root-test.outcome != 'success'
+      - name: fail if root test failed
         run: /bin/false
-        if: ${{ steps.root-test.outcome == 'failure' }}
+        if: steps.root-test.outcome != 'success'