Skip to content

Missing support for sending break to the serial port #25

@shankerwangmiao

Description

@shankerwangmiao

It seems that obmc-console does not support sending break to the serial port.

As I can see from the source code of phosphor-net-ipmid, it does support receiving break from IPMI clients, and forward this through an OOB message to the console server in

https://github.com/openbmc/phosphor-net-ipmid/blob/7c91cdd1cc7f8b4d2269d25e0d68cb352084aa45/sol/sol_manager.cpp#L78

However, the console server in this repo does not support receiving that OOB message and is unable to send break to the serial port in

rc = recv(client->fd, buf, sizeof(buf), MSG_DONTWAIT);

I suggest to change the receiving function from recv to recvmsg to handle the OOB message from phosphor-net-ipmid and use tcsendbreak(fd, 0) to forward the break signal to the serial port.

Sending break through serial port is important for system administrators to trigger Linux SysRq from SOL remotely.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions