Commit b1d3451
authored
fix(vector-io): replace inline::milvus with inline::sqlite-vec as default (#301)
[RHAIENG-3916](https://redhat.atlassian.net/browse/RHAIENG-3916)
# What does this PR do?
Milvus-lite acquires an exclusive file lock on startup, which prevents any second process from opening the database. This causes the LlamaStack pod to crash when configured with multiple workers. This PR replaces `inline::milvus` with `inline::sqlite-vec` as the always-enabled default vector_io provider.
The `remote::milvus` provider is unaffected.
## Test Plan
Manual verification only. Automated multi-worker vector_io testing is not included in this PR because `inline::sqlite-vec` currently opens SQLite without WAL mode or a busy timeout, which makes a 2-worker test unreliable under concurrent writes. [5344](ogx-ai/ogx#5344 (comment)) has been filed to address [`_create_sqlite_connection`](https://github.com/llamastack/llama-stack/blob/f7a10a4748a19979214f5a9d642945cc9b2ce36f/src/llama_stack/providers/inline/vector_io/sqlite_vec/sqlite_vec.py#L109); a smoke test covering multi-worker vector_io will be added once that fix lands.
- [X] Build the container image and verify `sqlite-vec` installs cleanly
- [X] Start the server and confirm vector_io operations work correctly with a single worker
- [X] Verify `remote::milvus` activates when `MILVUS_ENDPOINT` is set
## Summary by CodeRabbit
* **Changes**
* Switched the default vector database backend from Milvus to SQLite-Vec.
* Updated container dependencies and vector storage configuration to support the new backend.
* **Documentation**
* Updated provider documentation to reflect the new default vector database.
Approved-by: rhdedgar
Approved-by: cdoern3 files changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
| 61 | + | |
| 62 | + | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
0 commit comments