Card margin bottom

[msnassar]

I wonder why the card pattern is hardcoding the margin to the bottom?
https://github.com/openeuropa/oe_bootstrap_theme/blob/1.0.0-alpha7/templates/patterns/card/pattern-card--variant-search.html.twig#L56

I think the pattern should set the layout for the card itself only. If spacing is needed between a list of cards, we should leave this to the list itself? This is how it is implemented in BCL, see here https://oelibrary.netlify.app/ucpkn/?path=/story/features-project--listing

[tibi2303]

This is a big enhacement as we use the card component everywhere and will impact all the pages. We tried something on BCL (openeuropa/bootstrap-component-library#436) but it's hard to see the impact on all the existing implementations and it has been closed.

[msnassar]

@tibi2303 This issue is about the pattern-card--variant-search.html.twig only.
It is adding mb-3 to the card in order to have spacing between the items. That makes the result from the theme inconsistent with the result from BCL. See
Theme: https://digit-oesa.acc.fpfis.tech.ec.europa.eu/en/search?search_api_fulltext=tum
BCL: https://oelibrary.netlify.app/default/?path=/story/features-project--listing

In UCPKN, we have fixed the issue by creating a custom pattern ucpkn_listing_grid which is being used in the views instead of the unformatted list
https://github.com/digit-devs/echo-ucpkn-dev/tree/master/lib/themes/ucpkn_theme/templates/patterns/ucpkn_listing_grid