Commit 022d8b1
committed
Address review feedback
- Make the step card keyboard-selectable. The card root's onClick was
mouse-only; role="button" on the root is not an option because it wraps
the parameter inputs, so the step title becomes a real button with
aria-pressed, matching the canvas node pattern.
- Give the workflow canvas its own empty-state string. It rendered the
same emptyPipelineHint the step list shows, so the identical sentence
appeared twice whenever a model had no steps.
- Report fan-in as "Merging pipelines are not supported yet" instead of
reusing the branching message, which misled on a merge import.
- Cover the cycle branch that the existing test never reached: its
two-node loop carries two edges and is rejected by the earlier
edge-count check, so add a three-node fixture with a chain-sized edge
count that still leaves an untraversed loop, plus a merge-message test.1 parent 5c079cf commit 022d8b1
22 files changed
Lines changed: 75 additions & 4 deletions
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
811 | 811 | | |
812 | 812 | | |
813 | 813 | | |
814 | | - | |
| 814 | + | |
815 | 815 | | |
816 | 816 | | |
817 | 817 | | |
| |||
909 | 909 | | |
910 | 910 | | |
911 | 911 | | |
912 | | - | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
913 | 921 | | |
914 | | - | |
| 922 | + | |
915 | 923 | | |
916 | 924 | | |
917 | 925 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4316 | 4316 | | |
4317 | 4317 | | |
4318 | 4318 | | |
| 4319 | + | |
4319 | 4320 | | |
4320 | 4321 | | |
4321 | 4322 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4049 | 4049 | | |
4050 | 4050 | | |
4051 | 4051 | | |
| 4052 | + | |
4052 | 4053 | | |
4053 | 4054 | | |
4054 | 4055 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4059 | 4059 | | |
4060 | 4060 | | |
4061 | 4061 | | |
| 4062 | + | |
4062 | 4063 | | |
4063 | 4064 | | |
4064 | 4065 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4049 | 4049 | | |
4050 | 4050 | | |
4051 | 4051 | | |
| 4052 | + | |
4052 | 4053 | | |
4053 | 4054 | | |
4054 | 4055 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4049 | 4049 | | |
4050 | 4050 | | |
4051 | 4051 | | |
| 4052 | + | |
4052 | 4053 | | |
4053 | 4054 | | |
4054 | 4055 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4049 | 4049 | | |
4050 | 4050 | | |
4051 | 4051 | | |
| 4052 | + | |
4052 | 4053 | | |
4053 | 4054 | | |
4054 | 4055 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4049 | 4049 | | |
4050 | 4050 | | |
4051 | 4051 | | |
| 4052 | + | |
4052 | 4053 | | |
4053 | 4054 | | |
4054 | 4055 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3982 | 3982 | | |
3983 | 3983 | | |
3984 | 3984 | | |
| 3985 | + | |
3985 | 3986 | | |
3986 | 3987 | | |
3987 | 3988 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4049 | 4049 | | |
4050 | 4050 | | |
4051 | 4051 | | |
| 4052 | + | |
4052 | 4053 | | |
4053 | 4054 | | |
4054 | 4055 | | |
| |||
0 commit comments