Commit 57eb5d6
committed
Address review feedback
- Alignment gate: check each archive independently for extracted libraries.
`unzip ... || true` (needed because unzip exits 11 on "no matching files")
hid the case where a single APK or the AAB shipped no native code at all —
the aggregate `checked -eq 0` guard cannot see it, because the remaining
archives keep the total non-zero. Reproduced against the previous gate: an
APK containing zero .so alongside one good APK printed "All 1 native
libraries are 16 KB-aligned" and exited 0. Now fails, naming the archive.
- Reword the summary from "$bad segment(s) are not 16 KB-aligned" to
"$bad problem(s) found": `bad` also counts archives with no libraries and
files objdump cannot read, so the old wording misreported those failures.
- docs: the manual signing walkthrough still used `zipalign -p -f 4`, the very
4 KB-only flag this PR replaces with `-P 16` in CI. Anyone signing a release
by following the docs would have produced exactly the artifact Play rejects.1 parent 7aa2b79 commit 57eb5d6
2 files changed
Lines changed: 27 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
186 | 194 | | |
187 | 195 | | |
188 | 196 | | |
189 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
190 | 203 | | |
191 | 204 | | |
192 | 205 | | |
| |||
197 | 210 | | |
198 | 211 | | |
199 | 212 | | |
200 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
201 | 219 | | |
202 | 220 | | |
203 | 221 | | |
| |||
241 | 259 | | |
242 | 260 | | |
243 | 261 | | |
244 | | - | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
245 | 266 | | |
246 | 267 | | |
247 | 268 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
134 | 136 | | |
135 | 137 | | |
136 | 138 | | |
| |||
0 commit comments