Commit 6a695b8
committed
Address review feedback
- e2e/drop-overlay.spec.ts: drive the resize-handle test with a real
`click()` instead of `dispatchEvent("pointerdown")`. A synthetic pointer
event carries no active pointer id, so `startLayerPanelResize`'s
`setPointerCapture` could throw before the capture-phase recovery was
exercised, and the gesture never reached `pointerup` to tear the resize
down. Verified the test still fails when the listeners are moved back to
the bubble phase, so it remains a real regression test.
- DesktopShell.tsx: scope the "cannot occur during a real drag" claim to
the pointer listener only. HTML5 drag-and-drop suppresses mouse events
and a native drag holds an OS pointer grab, but neither spec promises
keyboard events are withheld, and the inline comment on `onKeyDown`
already assumed a keypress can arrive mid-drag. Escape is now described
for what it is: a conventional request to cancel the stranded overlay or
the drag itself.1 parent 1899ca0 commit 6a695b8
2 files changed
Lines changed: 6 additions & 7 deletions
Lines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1823 | 1823 | | |
1824 | 1824 | | |
1825 | 1825 | | |
1826 | | - | |
1827 | | - | |
1828 | | - | |
1829 | | - | |
1830 | | - | |
1831 | | - | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
| 1830 | + | |
1832 | 1831 | | |
1833 | 1832 | | |
1834 | 1833 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
0 commit comments