fix(stac): drop a request for items the user has since asked to leave

Author: clintonlunn

packages/plugins/src/plugins/maplibre-stac.ts

@@ -886,10 +886,10 @@ function buildPanel(container: HTMLElement): () => void {
 
   /** The tree asked for a collection: search it, and send the map to it. */
   function showCollection(href: string, bbox?: [number, number, number, number]): void {
-    void runSearch(false);
-    // The search this belongs to. Asking for a second collection while the first extent is still
-    // in flight would otherwise send the map where the user no longer is.
-    const generation = searchGeneration;
+    // The search this belongs to, taken before it starts rather than read back afterwards: asking
+    // for a second collection while the first extent is in flight must not move the map back.
+    const generation = ++searchGeneration;
+    void runSearch(false, generation);
     if (bbox) return void appRef?.fitBounds?.(bbox);
     // A collection guessed from its link has never been read, so its extent has to be fetched.
     void openCatalogNode(href, fetch, controller.signal)
@@ -899,9 +899,9 @@ function buildPanel(container: HTMLElement): () => void {
       .catch(() => undefined);
   }
 
-  async function runSearch(append: boolean): Promise<void> {
+  async function runSearch(append: boolean, generation = ++searchGeneration): Promise<void> {
     if (!connection) return;
-    const generation = ++searchGeneration;
+
     searchButton.disabled = true;
     loadMore.disabled = true;
     setStatus(append ? labels.loadingMore : labels.searching);